Fix build.py trying to pull Eloquence from non-existing website #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
commented
Apr 2, 2023
| shutil.copyfileobj(response, f) | ||
| shutil.copyfile(ORIGINAL_FILE_NAME, FILE_NAME) | ||
| print("Cannot find original Eloquence file. Will retrieve it manually.") | ||
| buildSystemPathToEloquence = r"%s\nvda\addons\Eloquence" %(os.getenv('APPDATA')) |
There was a problem hiding this comment.
Not sure if there is a better way to find appdata or work with paths in Windows.
| buildSystemPathToEloquence = r"%s\nvda\addons\Eloquence" %(os.getenv('APPDATA')) | ||
| if not os.path.exists(buildSystemPathToEloquence): | ||
| raise Exception("End of the road, cannot find original Eloquence.") | ||
| shutil.make_archive("eloquence-tmp", format="zip", root_dir=buildSystemPathToEloquence) |
| if not os.path.exists(buildSystemPathToEloquence): | ||
| raise Exception("End of the road, cannot find original Eloquence.") | ||
| shutil.make_archive("eloquence-tmp", format="zip", root_dir=buildSystemPathToEloquence) | ||
| os.system(f"rename eloquence-tmp.zip {FILE_NAME}") |
There was a problem hiding this comment.
Rename since this is tricky with the archive function above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the website pull with a local system search.