(PE-39577) Optimise legacy compiler support #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
2 times, most recently
from
4b1a560 to
b5b9ca5
Compare
ragingra
reviewed
Jan 20, 2025
plans/convert.pp
Outdated
| @@ -232,7 +232,7 @@ | |||
| run_plan('peadm::modify_certificate', $legacy_compiler_a_targets, | |||
| primary_host => $primary_target, | |||
| add_extensions => { | |||
| peadm::oid('pp_auth_role') => 'pe_compiler', | |||
| peadm::oid('pp_auth_role') => 'legacy_compiler', | |||
| peadm::oid('peadm_availability_group') => 'A', | |||
| peadm::oid('peadm_legacy_compiler') => 'true', | |||
There was a problem hiding this comment.
Think we won't need the true or false bit
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
from
b5b9ca5 to
9888996
Compare
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
12 times, most recently
from
d774ff3 to
9e5efc3
Compare
This commit: - Adds the `node_group_unpin` task. - `node_group_unpin` task is called in the convert plan to remove legacy compilers from from the PE Master node group. - Legacy compilers `pp_auth_role` changed to `legacy_compiler`. - Changes the PEADM config to use the PE Certificate Authority node group. - Removes peadm_legacy_compiler extension.
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
from
9e5efc3 to
1431087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will:
PE Masternode group after conversion.peadm::upgraderuns successfully after apeadm::convertpuppet infra configuredoes not remove classification rules that rely on trusted facts for legacy compilers.pp_auth_role=legacy_compileron legacy compiler nodes.PE Certificate Authoritynode group.peadm_legacy_compilerextension.Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?