Update checks #108
Merged
Update checks #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
added
the
maintenance
Recently, the checks action began failing because a newer version of Bundler (2.5.0) removed support for Ruby 2.6 and 2.7. Because the checks action runs on Ruby 2.7, the action started to fail. This commit: - Updates the Ruby version from 2.7 to 3.0. - Unpins Rubocop from a three-year-old verison. - Updates Rubocop's TargetRubyVersion from 2.4 to 2.6. - Addresses minor style offenses found by the updated Rubocop. - Removes the commit summary check, as Puppet no longer has a public Jira instance. (cherry picked from commit 16e2458)
mhashizume
force-pushed
the
maint/7.x/update-action
branch
from
70168c3 to
7529756
Compare
AriaXLi
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the checks action began failing because a newer version of Bundler (2.5.0) removed support for Ruby 2.6 and 2.7. Because the checks action runs on Ruby 2.7, the action started to fail.
This commit:
(cherry picked from commit 16e2458)