Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Muneer transposition model #2184
base: main
Are you sure you want to change the base?
Add Muneer transposition model #2184
Changes from 11 commits
02ae568
ea15728
feafcea
e4646d4
8066458
1798da8
4281d61
8b13595
6cd63a8
fa4d8e6
8318d5b
d5c8bc3
8cbee57
20c8fae
a326e94
e0d85c0
30fb33a
e1a7f74
618ca91
373d3e0
e517a84
9452248
b2d5239
36f633e
982d2f9
eecc05e
83b5036
6bd1d51
4fb4bae
4c69d6f
b93aa05
c2248f1
91fd117
b8910de
0591323
aed0e6d
2d4b10f
bec7412
a3e3e3c
927c8a8
7cfd605
5298cb2
ce6f5c0
ce42241
5632bda
b2128cf
f9fb65c
c0caf04
2142559
4e58192
bedd18b
b5e4aec
1bcf20d
c9b9214
519861e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the wording from perez. For consistency, should other functions also be updated or shall I keep the one that currently is (from perez)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echedey-ls edits are an improvement but I'm not in favor of changing documentation for other functions. You can change it here, but I think it's not a big deal if we use the old language.
Check warning on line 1039 in pvlib/irradiance.py
Codecov / codecov/patch
pvlib/irradiance.py#L1038-L1039
Check warning on line 1044 in pvlib/irradiance.py
Codecov / codecov/patch
pvlib/irradiance.py#L1044
Check warning on line 1046 in pvlib/irradiance.py
Codecov / codecov/patch
pvlib/irradiance.py#L1046