Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master into dev #106

Merged
merged 30 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7ec09a4
Merge pull request #95 from pwa-builder/dev
khmyznikov Nov 30, 2023
e7e8a52
Merge pull request #96 from pwa-builder/dev
khmyznikov Dec 4, 2023
195552b
add analytics for new app cap additions and fix typo
zateutsch Dec 5, 2023
b8aad89
Merge pull request #97 from pwa-builder/4496-update-analytics-for-app…
zateutsch Dec 12, 2023
f4e077f
Merge pull request #98 from pwa-builder/dev
khmyznikov Dec 13, 2023
b624c0a
Merge pull request #99 from pwa-builder/dev
khmyznikov Dec 13, 2023
9b1f804
Merge pull request #100 from pwa-builder/dev
khmyznikov Dec 14, 2023
a4bd165
move to using Azure Identity
jgw96 Sep 30, 2024
197724b
Add or update the Azure App Service build and deployment workflow config
jgw96 Oct 1, 2024
27eeb05
Update comp-fix_pwabuilder-apiv2-node(dev).yml
jgw96 Oct 1, 2024
b0fed91
Add or update the Azure App Service build and deployment workflow config
jgw96 Oct 1, 2024
6656e47
Update master_pwabuilder-apiv2-node.yml
jgw96 Oct 1, 2024
ed6e340
Merge pull request #101 from pwa-builder/comp-fix
jgw96 Oct 1, 2024
1090450
Revert "Comp fix"
jgw96 Oct 1, 2024
8c19bb8
Merge pull request #102 from pwa-builder/revert-101-comp-fix
jgw96 Oct 1, 2024
e4b2e71
remove cache location customization
jgw96 Oct 1, 2024
9824cff
Merge pull request #103 from pwa-builder/puppeteer-cache-fix
jgw96 Oct 1, 2024
f126c46
install chrome as part of build
jgw96 Oct 1, 2024
e4808ee
Merge pull request #104 from pwa-builder/puppeteer-cache-fix
jgw96 Oct 1, 2024
e0c79ca
set cachDir to manually downloaded chrome
jgw96 Oct 1, 2024
8d21fed
Merge pull request #105 from pwa-builder/puppeteer-cache-fix
jgw96 Oct 1, 2024
e44c7a7
Update .puppeteerrc.cjs
jgw96 Oct 1, 2024
14181f6
Update package.json
jgw96 Oct 1, 2024
373024f
Update master-to-prod.yml
jgw96 Oct 1, 2024
fb450a0
Update master-to-prod.yml
jgw96 Oct 2, 2024
ca4bd96
back to prev version of puppeteer
jgw96 Oct 2, 2024
1377768
update puppeteer
jgw96 Oct 2, 2024
29eb46b
Update master-to-prod.yml
jgw96 Oct 2, 2024
f00d82c
Update master-to-prod.yml
jgw96 Oct 2, 2024
6f2300b
Update master-to-prod.yml
jgw96 Oct 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/master-to-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,21 @@ env:

jobs:
build-and-deploy:
runs-on: ubuntu-latest
runs-on: self-hosted
environment: dev
steps:
- name: 'Checkout GitHub Action'
uses: actions/checkout@v3

- name: 'Login via Azure CLI'
uses: azure/login@v1
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS_PRINCIPAL }} # set up AZURE_RBAC_CREDENTIALS secrets in your repository

auth-type: IDENTITY
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZUREAPPSERVICE_TENANTID_BECF5140E58D4E4DAF8C3ECDD90CB3D3 }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
enable-AzPSSession: true

- name: Setup Node ${{ env.NODE_VERSION }} Environment
uses: actions/setup-node@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .puppeteerrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ const {join} = require('path');
module.exports = {
// Changes the cache location for Puppeteer.
cacheDirectory: join(__dirname, '.cache', 'puppeteer'),
};
};
2 changes: 1 addition & 1 deletion FindServiceWorker/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const httpTrigger: AzureFunction = async function (
else {
context?.log.warn(`FindServiceWorker: trying slow mode`);

const browser = await puppeteer.launch({headless: 'new' , args: ['--no-sandbox', '--disable-setuid-sandbox']});
const browser = await puppeteer.launch({headless: true , args: ['--no-sandbox', '--disable-setuid-sandbox']});
const page = await browser.newPage();
await page.setUserAgent(USER_AGENT);
await page.setRequestInterception(true);
Expand Down
2 changes: 1 addition & 1 deletion FindWebManifest/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ async function puppeteerAttempt(site: string, context?: Context): Promise<{error
try {
context?.log.warn(`FindWebManifest: trying slow mode`);

const browser = await puppeteer.launch({headless: 'new', args: ['--no-sandbox', '--disable-setuid-sandbox']});
const browser = await puppeteer.launch({headless: true, args: ['--no-sandbox', '--disable-setuid-sandbox']});
const page = await browser.newPage();
await page.setUserAgent(USER_AGENT);
await page.setRequestInterception(true);
Expand Down
8 changes: 4 additions & 4 deletions Report/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import { checkParams } from '../utils/checkParams.js';
import { getManifestByLink } from '../utils/getManifestByLink.js';
import {
analyzeServiceWorker,
AnalyzeServiceWorkerResponce,
AnalyzeServiceWorkerResponse,
} from '../utils/analyzeServiceWorker.js';
import { AnalyticsInfo, uploadToAppInsights } from '../utils/analytics.js';
import { Report } from './type.js';

import { dirname, join } from 'path';
import { dirname } from 'path';
import { fileURLToPath } from 'url';
import childProcess, { ChildProcess, exec, spawn } from 'child_process';
import { ChildProcess, exec, spawn } from 'child_process';

const __dirname = dirname(fileURLToPath(import.meta.url));
// const _root = `${__dirname}/../..`;
Expand Down Expand Up @@ -175,7 +175,7 @@ const audit = async (
url?: string;
};
} = {};
let swFeatures: AnalyzeServiceWorkerResponce | null = null;
let swFeatures: AnalyzeServiceWorkerResponse | null = null;

const processServiceWorker = async () => {
if (audits['service-worker-audit']?.details?.scriptUrl ) {
Expand Down
2 changes: 1 addition & 1 deletion Report/lighthouse/lighthouse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async function execute() {
`--disable-features=${disabledFeatures.join(',')}`,
// '--single-process'
],
headless: 'new',
headless: true,
defaultViewport: {
width: screenEmulationMetrics[desktop? 'desktop': 'mobile'].width,
height: screenEmulationMetrics[desktop? 'desktop': 'mobile'].height,
Expand Down
Loading
Loading