Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent launching client thread on exit #2278

Closed
wants to merge 1 commit into from
Closed

Prevent launching client thread on exit #2278

wants to merge 1 commit into from

Conversation

Gavriliuk
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #2278 into master will increase coverage by 2.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   71.35%   73.84%   +2.48%     
==========================================
  Files         138      137       -1     
  Lines       20205    21430    +1225     
==========================================
+ Hits        14418    15825    +1407     
+ Misses       5787     5605     -182     
Impacted Files Coverage Δ
src/unix/rtMutexNative.cpp 85.71% <0.00%> (-14.29%) ⬇️
examples/pxScene2d/src/pxImageA.cpp 72.99% <0.00%> (-10.25%) ⬇️
src/rtThreadPool.cpp 77.77% <0.00%> (-9.73%) ⬇️
src/unix/rtThreadPoolNative.cpp 70.83% <0.00%> (-5.29%) ⬇️
src/pxRect.h 51.06% <0.00%> (-4.94%) ⬇️
examples/pxScene2d/src/pxFont.cpp 73.35% <0.00%> (-4.82%) ⬇️
src/rtFileDownloader.cpp 66.76% <0.00%> (-4.60%) ⬇️
src/rtHttpCache.cpp 78.76% <0.00%> (-3.98%) ⬇️
src/rtScriptV8/jsCallback.cpp 85.07% <0.00%> (-3.64%) ⬇️
examples/pxScene2d/src/pxText.cpp 67.82% <0.00%> (-3.27%) ⬇️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d044041...fc5a210. Read the comment docs.

@Gavriliuk Gavriliuk closed this Aug 23, 2020
@Gavriliuk
Copy link
Contributor Author

Gavriliuk commented Aug 23, 2020

Duplicates #2277

@Gavriliuk Gavriliuk deleted the master-fix5-DELIA-45295 branch August 23, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant