-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: Include CHANGELOG.md and LICENSE in tool.flit.sdist #3101
base: main
Are you sure you want to change the base?
Conversation
Can ".flake8", ".pylintrc" and "tox.ini" be removed from the exclude array of tool.flit.sdist? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 52 52
Lines 8811 8811
Branches 1614 1614
=======================================
Hits 8501 8501
Misses 185 185
Partials 125 125 ☔ View full report in Codecov by Sentry. |
This is trying to remove the need for MANIFEST.in. I do not fully understand the build process so this PR may need further scrutiny. |
I recommend extending the existing CI workflows to check for some of the expected files in both distributions in the |
I did a test removing the contents in MANIFEST.in, but not amending anything else, and it passes the existing tests. |
This should be an automated test, not a manual one. And with distributions, I mean the sdist and bdist. |
May need some help with this, as still not understanding the process. Is this correct: bdist: .github/workflows/publish-to-pypi.yaml |
The workflow file you are mentioning and the When running |
No description provided.