Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add a comment #3106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MAINT: Add a comment #3106

wants to merge 1 commit into from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Feb 5, 2025

No description provided.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Feb 5, 2025

There should be more "\u0000" in this file. 0-23 (decimal) should be "\u0000" apart from 9, 10, and 13? See PDF 2.0 Table D.3.

On a test, making these changes gave errors. The values above are undefined for PDFDocEncoding so what we currently may need changing to get this totally correct.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (5a50b57) to head (d2dce5a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3106   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          52       52           
  Lines        8811     8811           
  Branches     1614     1614           
=======================================
  Hits         8501     8501           
  Misses        185      185           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Reading through the relevant issue which led to this change (#151), I am not completely sure about this.

What are the side-effects of having "unmuted" (it is no \u0000) everywhere? Why is 0x16 considered muted as an exception? If there is no clear answer to this, I would stay with the current list until someone provides a reliable (re)source telling otherwise.

@stefan6419846 stefan6419846 added needs-discussion The PR/issue needs more discussion before we can continue on-hold PR requests that need clarification before they can be merged.A comment must give details labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion The PR/issue needs more discussion before we can continue on-hold PR requests that need clarification before they can be merged.A comment must give details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants