Update dependencies and fix Windows compatibility on Python 3.12 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasertl
requested changes
Sep 30, 2024
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| "Topic :: System :: Hardware :: Hardware Drivers", | ||
| "Topic :: System :: Hardware :: Hardware Drivers :: Smartcard", | ||
| "Topic :: System :: Hardware :: Hardware Drivers :: Token" |
There was a problem hiding this comment.
Only minor comment: please leave the indentation intact. Hard to say what you changed here?
Comment on lines
-2
to
+7
| * /Distributed under the terms of the OASIS IPR Policy, | ||
| * [http://www.oasis-open.org/policies-guidelines/ipr], AS-IS, WITHOUT ANY | ||
| * IMPLIED OR EXPRESS WARRANTY; there is no warranty of MERCHANTABILITY, FITNESS FOR A | ||
| * PARTICULAR PURPOSE or NONINFRINGEMENT of the rights of others. | ||
| */ | ||
|
|
||
| /* Latest version of the specification: | ||
| * http://docs.oasis-open.org/pkcs11/pkcs11-base/v2.40/pkcs11-base-v2.40.html | ||
| /* | ||
| * PKCS #11 Specification Version 3.1 | ||
| * OASIS Standard | ||
| * 23 July 2023 | ||
| * Copyright (c) OASIS Open 2023. All Rights Reserved. | ||
| * Source: https://docs.oasis-open.org/pkcs11/pkcs11-spec/v3.1/os/include/pkcs11-v3.1/ | ||
| * Latest stage of narrative specification: https://docs.oasis-open.org/pkcs11/pkcs11-spec/v3.1/pkcs11-spec-v3.1.html |
There was a problem hiding this comment.
Distribution terms are no longer noted here. I think it's still good to keep them here, right?
|
To be transparent about the maintenance situation: I don't have any access to HSMs. I'm not sure about @kislyuk? This means that any changes cannot currently be tested with real HSMs. |
|
@mathiasertl I can't promise anything ongoing, but I might be able to run the tests on Linux against AWS CloudHSMv2, if that would be of any use? Someone would have to note down exactly how to run the tests though! (I'd rather not try to work it out, get it wrong, and invalidate the results.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up of the now closed PR #174. This new PR tries to update the PKCS#11 specification to the latest published version and brings compatibility to Python 3.12 on Windows.
The specific changes of this PR are:
The package has been tested on new virtual environments using Python 3.12 on Windows 11 with the asepkcs.dll (Athena Smartcard System ASE Card).