Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new images for keynote speakers. #38

Merged
merged 3 commits into from
Jan 6, 2020
Merged

add new images for keynote speakers. #38

merged 3 commits into from
Jan 6, 2020

Conversation

oonid
Copy link
Collaborator

@oonid oonid commented Jan 5, 2020

refer to #36
please note that:

  • the image size should be re-adjust
  • both images in a different orientation, don't know which one would be fit

@oonid oonid added the enhancement New feature or request label Jan 5, 2020
@oonid oonid requested a review from ridhof January 5, 2020 17:10
@ridhof
Copy link
Collaborator

ridhof commented Jan 6, 2020

adjust styling sedikit di commit saya sebelumnya mas, tapi masih belum solved main issuenya -> style halaman jadi hancur ketika gambar nya tidak sesuai (yakni gambar yang memanjang / atas-bawah) jadi dari sini tau kalau styling yang saya buat lebih cocok ke gambar yang kotak / melebar.

gambar

apa mas @oonid bisa mengganti gambar yang memanjang tsb menjadi melebar? atau perlu dibantu? 😄

@oonid
Copy link
Collaborator Author

oonid commented Jan 6, 2020

ok mas Ridho,
I will try to make the image to be square, later.

@oonid
Copy link
Collaborator Author

oonid commented Jan 6, 2020

mas @ridhof
I have resized the image of bu Inge, now it's square.
please test again, and merge if it is done.
thank you.

Copy link
Collaborator

@ridhof ridhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job mas @oonid , finally square image performs better at mobile version.
going to write it at issue so that other upcoming contributors would use the square version of the picture.

@ridhof ridhof merged commit 110f60e into master Jan 6, 2020
@oonid oonid deleted the speakers_images branch January 6, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants