-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Numpy build-time requirement (time sensitive) #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
4349854
to
eb01308
Compare
@rdbisme @neutrinoceros I've now simplified this to remove any unnecessary changes |
I think this is good to go? |
rdbisme
reviewed
Apr 18, 2024
Since it is not needed anymore with recent Numpy versions, and bump minimum required Numpy to 2.0.0rc1 in order to be able to build Numpy 2-compatible wheels
Hello! Any plans to push a pre-release out with this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
oldest-supported-numpy
is no longer needed (see https://numpy.org/doc/stable/dev/depending_on_numpy.html#build-time-dependency for example), so we can get rid ofoldest-supported-numpy
in the build-time dependencies inpyproject.toml
and just usenumpy
numpy>=2.0.0rc1
. Then, if/once this PR is merged, new wheels of bottleneck should ideally be built ASAP.requires=
field fromsetup.py
, updatedsetup_requires
to also require Numpy 2.0.0rc1 or later.Without this PR: