Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish linux arm64 wheels #464

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mark-thm
Copy link

We'd like to use bottleneck on Linux arm64 machines and it'd be great to consume a wheel instead of an sdist for that.

Following the guide at https://cibuildwheel.pypa.io/en/stable/faq/#emulation, cibuildwheel supports QEMU emulation to make the arm64 build work.

@rdbisme
Copy link
Collaborator

rdbisme commented Oct 24, 2024

Thanks.

I'm reasonably convinced this still needs to be fixed: #394

@mark-thm
Copy link
Author

Oh, interesting -- I'm able to successfully install (and thus build) from sdist on Ubuntu 22.04 running on an arm64 machine.

@rdbisme
Copy link
Collaborator

rdbisme commented Oct 24, 2024

Ok! Any chance you might contribute also in the tests section of the CI? That will allow us to be sure it works. I'm not 100% sure on how to do that, I hope Github actions has Arm64 runners.

@mark-thm
Copy link
Author

Running some experiments on another repo about getting Python tests running on arm64 Linux runners but not having much success. GitHub is not yet supporting Linux/arm64 runners for OSS projects, so I’m not able to do this natively.

I’m confident in the cibuildwheel support (just followed their docs).

Some ideas here:

  • run the cibuildwheel build minus the publishing component in CI (don’t think this will run your tests but it will show that the library successfully builds)
  • run the tests in a qemu emulated docker container
  • don’t modify the test portion

@groodt
Copy link

groodt commented Oct 25, 2024

GitHub hopefully will have Arm64 for OSS by end of year. https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/

So hopefully that holds true.

@ollie-bell
Copy link

ollie-bell commented Oct 28, 2024

Just chiming in to say thanks for doing this and do let me know if any additional help is needed!

Fixing this issue will simplify a Dockerfile for our dev's working on macOS arm64 locally :D Docker therefore is running locally on linux/arm64 and no wheel exists for bottleneck there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants