Psutil 3 Upgrade #350
Open
Psutil 3 Upgrade #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same code as before virtually just slightly different flow. Old tests still pass with this however.
|
@guidow, PTAL |
|
|
||
| elif nic.family == socket.AF_INET6: | ||
| logger.warning( | ||
| "IPv6 not yet supported in addresses() for %s", name) |
There was a problem hiding this comment.
While I am still in favor of supporting IPv6 eventually, until we actually officially try to do so, we should get rid of this warning, IMHO. It just clutters the logs with urgent looking warnings without actually being important at all.
There was a problem hiding this comment.
This should be covered in 511941a
|
I'm generally in favor of removing the dependency on netifaces, but see my other comments. |
|
@guidow, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our
sysinfo.networkmodule to use Psutil 3.0. By doing this we're also able to remove netifaces as a dependency and simplify the code some.