typing: add a bunch of -> None for obvious cases

pyinfra/api/command.py

@@ -236,7 +236,7 @@ def execute(self, state: "State", host: "Host", connector_arguments: ConnectorAr
         if "state" in argspec.args and "host" in argspec.args:
             return self.function(state, host, *self.args, **self.kwargs)
 
-        def execute_function():
+        def execute_function() -> None:
             with ctx_config.use(state.config.copy()):
                 with ctx_host.use(host):
                     self.function(*self.args, **self.kwargs)

pyinfra/api/config.py

@@ -224,10 +224,10 @@ def set_current_state(self, config_state):
         for key, value in config_state:
             setattr(self, key, value)
 
-    def lock_current_state(self):
+    def lock_current_state(self) -> None:
         self._locked_config = self.get_current_state()
 
-    def reset_locked_state(self):
+    def reset_locked_state(self) -> None:
         self.set_current_state(self._locked_config)
 
     def copy(self) -> "Config":

pyinfra/api/host.py

@@ -361,7 +361,7 @@ def get_fact(self, name_or_cls, *args, **kwargs):
     # Connector proxy
     #
 
-    def _check_state(self):
+    def _check_state(self) -> None:
         if not self.state:
             raise TypeError("Cannot call this function with no state!")
 
@@ -403,7 +403,7 @@ def connect(self, reason=None, show_errors: bool = True, raise_exceptions: bool
                 self.state.trigger_callbacks("host_connect", self)
                 self.connected = True
 
-    def disconnect(self):
+    def disconnect(self) -> None:
         """
         Disconnect from the host using it's configured connector.
         """

pyinfra/api/state.py

@@ -122,7 +122,7 @@ class StateHostMeta:
     ops_no_change = 0
     op_hashes: set[str]
 
-    def __init__(self):
+    def __init__(self) -> None:
         self.op_hashes = set()
 
 

pyinfra/connectors/chroot.py

@@ -22,7 +22,7 @@
 
 
 @memoize
-def show_warning():
+def show_warning() -> None:
     logger.warning("The @chroot connector is in beta!")
 
 

pyinfra/connectors/docker.py

@@ -129,7 +129,7 @@ def connect(self) -> None:
                 self.container_id = _start_docker_image(docker_identifier)
 
     @override
-    def disconnect(self):
+    def disconnect(self) -> None:
         container_id = self.container_id
 
         if self.no_stop:

pyinfra/connectors/dockerssh.py

@@ -22,7 +22,7 @@
 
 
 @memoize
-def show_warning():
+def show_warning() -> None:
     logger.warning("The @dockerssh connector is in beta!")
 
 

pyinfra/connectors/local.py

@@ -210,7 +210,7 @@ def get_file(
         return True
 
     @override
-    def check_can_rsync(self):
+    def check_can_rsync(self) -> None:
         if not which("rsync"):
             raise NotImplementedError("The `rsync` binary is not available on this system.")
 

pyinfra/connectors/ssh.py

@@ -543,7 +543,7 @@ def put_file(
         return True
 
     @override
-    def check_can_rsync(self):
+    def check_can_rsync(self) -> None:
         if self.data["ssh_key_password"]:
             raise NotImplementedError(
                 "Rsync does not currently work with SSH keys needing passwords."

pyinfra/connectors/terraform.py

@@ -9,7 +9,7 @@
 
 
 @memoize
-def show_warning():
+def show_warning() -> None:
     logger.warning("The @terraform connector is in beta!")
 
 

pyinfra/connectors/util.py

@@ -232,7 +232,7 @@ def remove_any_sudo_askpass_file(host) -> None:
 
 
 @memoize
-def _show_use_su_login_warning():
+def _show_use_su_login_warning() -> None:
     logger.warning(
         (
             "Using `use_su_login` may not work: "

pyinfra/context.py

@@ -27,7 +27,7 @@ class ContextObject:
     _container_cls = container
     _base_cls: ModuleType
 
-    def __init__(self):
+    def __init__(self) -> None:
         self._container = self._container_cls()
         self._container.module = None
 
@@ -96,7 +96,7 @@ def set(self, module):
     def set_base(self, module):
         self.context._base_cls = module
 
-    def reset(self):
+    def reset(self) -> None:
         self.context._container.module = None
 
     def isset(self):

pyinfra/facts/iptables.py

@@ -37,7 +37,7 @@ def parse_iptables_rule(line):
     args: list[str] = []
     not_arg = False
 
-    def add_args():
+    def add_args() -> None:
         arg_string = " ".join(args)
 
         if key and key in IPTABLES_ARGS:

pyinfra/operations/files.py

@@ -665,7 +665,7 @@ def sync(
 
 
 @memoize
-def show_rsync_warning():
+def show_rsync_warning() -> None:
     logger.warning("The `files.rsync` operation is in alpha!")
 
 

pyinfra_cli/main.py

@@ -34,7 +34,7 @@
 from .virtualenv import init_virtualenv
 
 
-def _exit():
+def _exit() -> None:
     if ctx_state.isset() and state.failed_hosts:
         sys.exit(1)
     sys.exit(0)

pyinfra_cli/prints.py

@@ -130,7 +130,7 @@ def print_facts(facts):
         print_fact(data)
 
 
-def print_support_info():
+def print_support_info() -> None:
     from importlib.metadata import PackageNotFoundError, requires, version
 
     from packaging.requirements import Requirement

pyinfra_cli/virtualenv.py

@@ -6,7 +6,7 @@
 from pyinfra import logger
 
 
-def init_virtualenv():
+def init_virtualenv() -> None:
     """
     Add a virtualenv to sys.path so the user can import modules from it.
     This isn't perfect: it doesn't use the Python interpreter with which the