Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facts: add efibootmgr.EFIBootMgr #1231

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

bauen1
Copy link
Contributor

@bauen1 bauen1 commented Oct 31, 2024

Add a fact that parses the output of efibootmgr.

Currently based on #1179 #1250

@bauen1 bauen1 force-pushed the feature/facts-efibootmgr branch 3 times, most recently from a57b426 to efe6c0f Compare October 31, 2024 15:05
@bauen1 bauen1 force-pushed the feature/facts-efibootmgr branch 3 times, most recently from ca54c8a to 4bce353 Compare November 30, 2024 17:05
@bauen1 bauen1 marked this pull request as ready for review November 30, 2024 17:07
@bauen1 bauen1 force-pushed the feature/facts-efibootmgr branch from 4bce353 to ccad2c1 Compare December 19, 2024 13:54
@bauen1 bauen1 force-pushed the feature/facts-efibootmgr branch from ccad2c1 to c8518df Compare January 2, 2025 13:43
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @bauen1!

@@ -50,6 +50,16 @@ scripts/dev-test.sh

Use `pytest` to run the unit tests, or `pytest --cov` to run with coverage. Pull requests are expected to be tested and not drop overall project coverage by >1%.

To limit the pytests to a specific fact or operation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is such a good add to this doc 👍

@Fizzadar Fizzadar merged commit 7147572 into pyinfra-dev:3.x Jan 3, 2025
23 checks passed
@bauen1 bauen1 deleted the feature/facts-efibootmgr branch January 4, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants