Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos + CI #1234

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Fix typos + CI #1234

merged 3 commits into from
Nov 17, 2024

Conversation

simonhammes
Copy link
Contributor

@simonhammes simonhammes commented Oct 31, 2024 •
edited
Loading

Closes #1101

@simonhammes simonhammes marked this pull request as ready for review November 17, 2024 00:03
Fizzadar
Fizzadar approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to have a performant spell checking in CI at last 💪 Thanks @simonhammes!

@Fizzadar Fizzadar merged commit ef8acef into pyinfra-dev:3.x Nov 17, 2024
23 checks passed
@simonhammes simonhammes deleted the 1101-typos branch November 17, 2024 13:49
@simonhammes
Copy link
Contributor Author

simonhammes commented Nov 17, 2024 •
edited
Loading

Nice! Great to have a performant spell checking in CI at last 💪 Thanks @simonhammes!

I just realized I forgot to drop flake8-spellcheck - I can send another PR

EDIT: If that should even happen - typos and flake8-spellcheck do not follow the same approach: https://github.com/crate-ci/typos?tab=readme-ov-file#why-was--not-corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fizzadar Fizzadar Fizzadar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use typos (+ drop flake8-spellcheck)
2 participants
@simonhammes @Fizzadar