Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Refactor the Executor interface #548

Merged
merged 33 commits into from
Feb 3, 2025
Merged

[major] Refactor the Executor interface #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
97a0920
[major] Refactor the Executor interface
jan-janssen Feb 1, 2025
07c27a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2025
fc0298c
fix test
jan-janssen Feb 1, 2025
f3b8616
update benchmark
jan-janssen Feb 1, 2025
0b38e5f
move interfaces to individual modules
jan-janssen Feb 1, 2025
41ca2ad
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2025
9f61c6e
Merge remote-tracking branch 'origin/main' into interface
jan-janssen Feb 1, 2025
4e903bc
fixes
jan-janssen Feb 1, 2025
7c19964
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2025
2e09bdc
Merge remote-tracking branch 'origin/main' into interface
jan-janssen Feb 1, 2025
1fb1859
remove create
jan-janssen Feb 1, 2025
57c5242
Merge remote-tracking branch 'origin/interface' into interface
jan-janssen Feb 1, 2025
4f4516b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2025
454b336
remove redundant functionality
jan-janssen Feb 1, 2025
b89bca7
Move graph tests
jan-janssen Feb 1, 2025
89240d2
remove core check
jan-janssen Feb 1, 2025
8f01dfa
clean up
jan-janssen Feb 1, 2025
d9fcc61
more tests
jan-janssen Feb 1, 2025
28185b2
fix import
jan-janssen Feb 1, 2025
685c5dc
more fixes
jan-janssen Feb 1, 2025
672196e
Rename LocalExecutor to SingleNodeExecutor
jan-janssen Feb 1, 2025
5072318
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 1, 2025
8a37e60
test block allocation
jan-janssen Feb 1, 2025
d261621
Merge remote-tracking branch 'origin/interface' into interface
jan-janssen Feb 1, 2025
b7d5a8c
fix
jan-janssen Feb 1, 2025
a0bfc9f
flux fix
jan-janssen Feb 1, 2025
abeac75
Rename interfaces
jan-janssen Feb 2, 2025
814c0d2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 2, 2025
acf4693
fix docstrings
jan-janssen Feb 2, 2025
0fe7dfe
add docstrings to create_*_executor() function
jan-janssen Feb 3, 2025
87b3380
fix test
jan-janssen Feb 3, 2025
9fd0ec3
Merge remote-tracking branch 'origin/main' into interface
jan-janssen Feb 3, 2025
0cf4b6a
merge
jan-janssen Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittest-flux-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
timeout-minutes: 5
run: >
flux start
python -m unittest tests/test_flux_executor.py tests/test_executor_backend_flux.py tests/test_cache_executor_pysqa_flux.py;
python -m unittest tests/test_flux_executor.py tests/test_executor_backend_flux.py tests/test_cache_executor_pysqa_flux.py tests/test_plot_dependency_flux.py;
2 changes: 1 addition & 1 deletion .github/workflows/unittest-flux-openmpi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
timeout-minutes: 5
run: >
flux start
coverage run -a --omit="executorlib/_version.py,tests/*" -m unittest tests/test_flux_executor.py tests/test_executor_backend_flux.py tests/test_cache_executor_pysqa_flux.py;
coverage run -a --omit="executorlib/_version.py,tests/*" -m unittest tests/test_flux_executor.py tests/test_executor_backend_flux.py tests/test_cache_executor_pysqa_flux.py tests/test_plot_dependency_flux.py;
coverage xml
env:
PYMPIPOOL_PMIX: "pmix"
Expand Down
260 changes: 14 additions & 246 deletions executorlib/__init__.py
View file
Open in desktop

Large diffs are not rendered by default.

295 changes: 0 additions & 295 deletions executorlib/interactive/create.py
View file
Open in desktop

This file was deleted.

Empty file added executorlib/interfaces/__init__.py
View file
Open in desktop
Empty file.
Loading
Loading