Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle future resource #710

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Handle future resource #710

wants to merge 1 commit into from

Conversation

niklassiemer
Copy link
Member

closes #701

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/res_future

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Pull Request Test Coverage Report for Build 5203680070

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 12.976%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_contrib/generic/coscineIo.py 1 3 33.33%
Totals Coverage Status
Change from base Build 5202290759: 0.005%
Covered Lines: 1660
Relevant Lines: 12793
💛 - Coveralls

@niklassiemer
Copy link
Member Author

@pmrv I never actually used Futures, yet. And for some reasons it worked on my end so far with the old implementation... Could you check if this branch fixes the issue? Thanks 😄

@niklassiemer
Copy link
Member Author

@pmrv could you check if the issue is fixed with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coscine: Creating Resources fails
1 participant
@niklassiemer