Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cli: remove a misleading warning #719

Merged
merged 2 commits into from
Jan 7, 2024
Merged

_cli: remove a misleading warning #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd88f1
_cli: remove a misleading warning
woodruffw Jan 5, 2024
a9e405c
CHANGELOG: record changes
woodruffw Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ All versions prior to 0.0.9 are untracked.

## [Unreleased]

### Fixed

* Removed a misleading warning message that resulted in user confusion
([#719](https://github.com/pypa/pip-audit/pull/719))

## [2.6.2]

### Changed
Expand Down
3 changes: 0 additions & 3 deletions pip_audit/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,6 @@ def audit() -> None: # pragma: no cover
if args.require_hashes and args.no_deps:
logger.warning("The --no-deps flag is redundant when used with --require-hashes")

if args.no_deps and args.disable_pip:
logger.warning("The --no-deps flag is redundant when used with --disable-pip")

if args.require_hashes and isinstance(service, OsvService):
logger.warning(
"The --require-hashes flag with --service osv only enforces hash presence NOT hash "
Expand Down