Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): add a new endpoint for status #319

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

RonanMorgan
Copy link
Collaborator

An endpoint can be useful for further automation (and I need in order to launch the dev env automatically)

@RonanMorgan RonanMorgan self-assigned this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.34%. Comparing base (b3572c2) to head (80c0069).

Files Patch % Lines
src/app/main.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   94.39%   94.34%   -0.05%     
==========================================
  Files          66       66              
  Lines        1676     1679       +3     
==========================================
+ Hits         1582     1584       +2     
- Misses         94       95       +1     
Flag Coverage Δ
client 90.58% <ø> (ø)
unittests 94.54% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Good idea to have proper healthcheck in the docker. For simplicity purposes, could you move that endpoint to main.py please? (i.e. instead of "/status/get-status", let's do "/status" or "/health")

@RonanMorgan
Copy link
Collaborator Author

done

@frgfm
Copy link
Member

frgfm commented Apr 18, 2024

@RonanMorgan sorry I meant deleting the src/app/api/endpoints/status.py and directly put it in main.py 😅
With your last commit, the endpoint is accessible at /status/status which is a bit redondant :)

@RonanMorgan
Copy link
Collaborator Author

RonanMorgan commented Apr 22, 2024

well I had removed the prefix="/status" to avoid this behavior ("/status/status") but ok I can refactor to put the code in main.py

@RonanMorgan
Copy link
Collaborator Author

done

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frgfm frgfm added this to the 0.2.0 milestone Apr 24, 2024
@frgfm frgfm changed the title Add a new endpoint for status feat(main): add a new endpoint for status Apr 24, 2024
@frgfm frgfm merged commit 767be30 into main Apr 24, 2024
28 of 30 checks passed
@frgfm frgfm deleted the rs/add-status-endpoint branch April 24, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants