-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(main): add a new endpoint for status #319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 94.39% 94.34% -0.05%
==========================================
Files 66 66
Lines 1676 1679 +3
==========================================
+ Hits 1582 1584 +2
- Misses 94 95 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Good idea to have proper healthcheck in the docker. For simplicity purposes, could you move that endpoint to main.py please? (i.e. instead of "/status/get-status", let's do "/status" or "/health")
done |
@RonanMorgan sorry I meant deleting the src/app/api/endpoints/status.py and directly put it in main.py 😅 |
well I had removed the prefix="/status" to avoid this behavior ("/status/status") but ok I can refactor to put the code in main.py |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
An endpoint can be useful for further automation (and I need in order to launch the dev env automatically)