Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save media in a "site" bucket #323

Closed
wants to merge 2 commits into from
Closed

Conversation

RonanMorgan
Copy link
Collaborator

Pyronear

This is a first step to start this refactor : gathering images per site / installation.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 94.43%. Comparing base (767be30) to head (8dd60c1).

Files Patch % Lines
src/app/api/endpoints/media.py 63.63% 4 Missing ⚠️
src/app/services/storage.py 60.00% 4 Missing ⚠️
src/app/api/deps.py 83.33% 2 Missing ⚠️
src/app/services/services.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   94.54%   94.43%   -0.11%     
==========================================
  Files          63       63              
  Lines        1594     1600       +6     
==========================================
+ Hits         1507     1511       +4     
- Misses         87       89       +2     
Flag Coverage Δ
unittests 94.43% <69.44%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm
Copy link
Member

frgfm commented Jun 23, 2024

Thanks for the PR :)
The description mostly comes from the illustration, so am I understanding this clearly: we create one bucket per entity (organization now I guess?)

@RonanMorgan
Copy link
Collaborator Author

well the schema is a bit outdated : I did some calculation with OVH Cold Archive vs OVH S3 and for now it would cose only few euros to keep years of data

but yes I would like to have one bucket per organization :)

@frgfm frgfm deleted the rs/new-bucket-behavior branch July 2, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants