Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detections): restrict webhook and telegram to sequence creation #416

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jan 17, 2025

As mentioned in #413, I think the webhook trigger and Telegram notifications should only be considered when a sequence is created (several detections in a row from the same camera and azimuth) vs. when a detection is created (more prone to false positives and noise).

This PR moves both to sequence creation

@frgfm frgfm added the type: improvement New feature or request label Jan 17, 2025
@frgfm frgfm added this to the 0.2.0 milestone Jan 17, 2025
@frgfm frgfm self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (6c8b02f) to head (bd2c7e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/app/api/api_v1/endpoints/detections.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          38       38           
  Lines        1097     1097           
=======================================
  Hits          935      935           
  Misses        162      162           
Flag Coverage Δ
backend 84.57% <0.00%> (ø)
client 93.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm marked this pull request as ready for review January 17, 2025 10:30
@frgfm frgfm merged commit 840640c into main Jan 17, 2025
26 of 27 checks passed
@frgfm frgfm deleted the frgfm/telegram branch January 17, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant