Replace twiiter icon with Bluesky #72
Conversation
|
Hi there, thanks a lot for your PR ! After discussions, we have decided to only remove twitter icon (not replacing by bluesky) |
_includes/contact.html
Outdated
| </div> | ||
| <div class="col-sm-2 col-sm-offset-2 text-center"> | ||
| <a href="https://bsky.app/profile/pyronear.bsky.social" target="_blank"> | ||
| <img src="{{ site.base-url }}/img/bluesky-icon.png" alt="BlueSky" style="width: 25px; height: 28px;" /> |
There was a problem hiding this comment.
In the end, lets just remove this icon
img/update.png
Outdated
There was a problem hiding this comment.
Thanks a lot for providing the screen in the PR !
However, can you remove it here ?
There was a problem hiding this comment.
Sure! I'll remove the image now. Thanks for the feedback.
|
I've resolved all conflicts and updated the PR as requested. Could you please review again? |
|
thanks a lot @rishipandey2 ! |
|
Also, there are some conflicts to handle in _config.yml (you can solve them probably merging main to your current branch) |
|
@fe51 I have centered the icons as requested. Please review and let me know if any further adjustments are needed. |
|
@fe51 I am resolving all the conflicts and pushing changes but github is showing those conflicts again? |
|
hum, have you been pulling the last version of master/main ? to solve conflicts localy. it seems the changes needed are related to updates that have been meerged since you have been working one the PR. If it is not that, I will handle conflicts myself. :) |
|
"Okay @fe51, otherwise, I can try once again! And about centering the icons—do they need any adjustments ? |
|
Yes @rishipandey2 if it is easier for you, you can start a new PR from the actual master branch (removing twitter and centering the 2 icons that left) Thanks :) |
|
okay @fe51 :) |
📰 Short Description
This update removes the Twitter link in the footer and replaces it with the BlueSky profile link for Pyronear. The change ensures that the website reflects the current social media presence. Additionally, the BlueSky icon color has been changed to black to maintain a consistent visual theme.
This resolves issue #70, where the Twitter link needed to be replaced due to Pyronear's departure from Twitter (now X).
📸 Screenshots
Guidelines
Translation
If your modification includes text, it is likely that you are not fluent in one of the languages in which the site is distributed. In this case, we suggest that you use DeepL for translation and specify the languages for which you have used it.
Deepl used for translation in:
List order for media
If your modification consists in adding a media info, please add it at the top of the list (the most recent to appears first).
List order for sponsors and partners
Reversely, if your modification consists in adding a sponsor or partner, please add it at the end of the list.
🥳 Thanks a lot for your contribution 🎆