Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level up the cookie security #29

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

ArtyomVancyan
Copy link
Member

Motivation:

This fixes #27 issue reported by @vokimon. It uses the Secure attribute with an appropriate value based on allow_http and strictly sets the Httponly for the authorization cookie.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@ArtyomVancyan ArtyomVancyan changed the title Security levelup Level up the cookie security Oct 13, 2023
@ArtyomVancyan ArtyomVancyan merged commit cc28bda into pysnippet:master Oct 13, 2023
12 checks passed
@ArtyomVancyan ArtyomVancyan deleted the security-levelup branch October 13, 2023 15:20
@ArtyomVancyan ArtyomVancyan added the hacktoberfest-accepted Accepted by maintainers for Hacktoberfest label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted by maintainers for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report - config.allow_http used for two apparently unrelated purposes
1 participant