Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter samesite for set_cookie #50

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

jung-hunsoo
Copy link
Contributor

Motivation:

For some cases, a cross-site cookie settings are required to support different domain.

This PR allow developers to override the samesite value defaults to lax.

(More on https://www.starlette.io/responses/#set-cookie)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@ArtyomVancyan ArtyomVancyan merged commit 33b42dc into pysnippet:master Sep 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants