Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when z3 is missing and add transform error reporting #1118

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented Dec 7, 2024

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This pull request fixes #1117 and adds logging for when Z3Visitor and CFGVisitor fail to run. In particular, this will report a warning if the z3 option is enabled, but z3-solver was not installed.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12213927042

Details

  • 6 of 12 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.861%

Changes Missing Coverage Covered Lines Changed/Added Lines %
python_ta/patches/transforms.py 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
python_ta/patches/transforms.py 1 66.67%
Totals Coverage Status
Change from base Build 12098022807: -0.1%
Covered Lines: 3104
Relevant Lines: 3379

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 75163b9 into pyta-uoft:master Dec 7, 2024
9 of 15 checks passed
@david-yz-liu david-yz-liu deleted the issue-1117 branch December 7, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional import for z3 dependency in transforms.py
2 participants