Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Kedro hooks link #478

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix broken Kedro hooks link #478

merged 1 commit into from
Jan 31, 2024

Conversation

simonw
Copy link
Contributor

@simonw simonw commented Jan 30, 2024

The Kedro link on https://pluggy.readthedocs.io/en/stable/#more-real-world-examples

To see how pluggy is used in the real world, have a look at these projects documentation and source code:

Links to https://docs.kedro.org/en/latest/kedro.framework.hooks.specs.html which returns a 404 error

I think https://docs.kedro.org/en/latest/hooks/introduction.html is a better page to link to here.

@simonw
Copy link
Contributor Author

simonw commented Jan 30, 2024

The test failure here was from codecov which shouldn't be relevant to this change since it is documentation only.

@simonw
Copy link
Contributor Author

simonw commented Jan 30, 2024

I ran the Sphinx build locally to confirm that this produces the correct URL, and it does.

cd pluggy/docs
pip install -r requirements.txt
pip install -e ..
sphinx-build . out
open out/index.html

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluetech bluetech merged commit eae11ef into pytest-dev:main Jan 31, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants