Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #566

Merged
merged 2 commits into from
Feb 25, 2025
Merged

[pre-commit.ci] pre-commit autoupdate #566

merged 2 commits into from
Feb 25, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 10, 2025 •
edited
Loading

@Pierre-Sassoulas
Copy link
Member

The mypy fail was:

src/pluggy/_callers.py:35: error: Item "Generator[None, Result[object], None]" of 
"Generator[None, Result[object], None] | Generator[None, object, object]" 
has no attribute "gi_code"  [union-attr]
src/pluggy/_callers.py:35: error: Item "Generator[None, object, object]" of
 "Generator[None, Result[object], None] | Generator[None, object, object]"
has no attribute "gi_code"  [union-attr]
Found 2 errors in 1 file (checked 18 source files)

I'd like a review by someone who actually knows what's happening :)

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
7f2fe82 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.4 → v0.9.7](astral-sh/ruff-pre-commit@v0.9.4...v0.9.7)
- [github.com/pre-commit/mirrors-mypy: v1.14.1 → v1.15.0](pre-commit/mirrors-mypy@v1.14.1...v1.15.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 9adb3d3 to 7f2fe82 Compare February 24, 2025 20:04
@Pierre-Sassoulas
Copy link
Member

@nicoddemus would you mind reviewing please ? The pre-commit bot is removing modifications so I had to redo the noqa from 2 weeks ago :)

nicoddemus
nicoddemus approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

@nicoddemus nicoddemus merged commit 863e6bc into main Feb 25, 2025
27 of 29 checks passed
@Pierre-Sassoulas
Copy link
Member

No problem, I should have asked for a review then

@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch February 25, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierre-Sassoulas @nicoddemus