Fix internal error caused by pytest.skip statements #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing pytest's module Module.obj to attach a scoped event loop fixture triggers a module import executing module-level statements. A module-level pytest.skip statement raises the Skipped OutcomeException or a Collector.CollectError. These cases are handled correctly when they happen inside Collector.collect(), but the scoped event loop is attached in pytest_collectstart which runs before the actual collect call. This causes pytest.skip statements to trigger a pytest INTERNALERROR.
This PR catches the exceptions and aborts the attachment of the scoped event loop fixture to the module. Since all tests in the module are skipped, a missing module-scoped loop shouldn't be an issue, because there are no tests that can potentially request it.
This is essentially the same approach as in #656
Resolves #701