This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Raising error in HTTP11Response if created with illegal attributes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! The patch fails the linter: do you mind cleaning that up? |
AvivC
force-pushed
the
validate-http11-response-info
branch
2 times, most recently
from
1d8f94b
to
1fb6f2b
Compare
An HTTP response must either specify a content-length header, specify 'close' for a connection header to signal that the connection will be closed after the response, or be a chunked response. If none of these conditions are true, we raise a detailed ValueError, instead of the plain assertion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An HTTP response must either specify a content-length header, specify
'close' for a connection header to signal that the connection will be
closed after the response, or be a chunked response.
If none of these conditions are true, we raise a detailed ValueError,
instead of the plain assertion.