GHA: Test MSYS2/CLANG64 #6888
GHA: Test MSYS2/CLANG64 #6888
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
I've rerun the tests, and they've passed now. |
|
Thank you for this PR! What's the benefit in adding all of these environments? Our build matrix is pretty big right now, so let's be careful not to make it too much bigger. This increases the test jobs in this worfklow from 2 to 5, and total duration from ~12 to ~21 mins:
That's on top of 61 checks at the moment (mostly but not all GHA), taking about 184 mins of GHA time (wall-clock time maybe about an hour?). For example, we aren't testing the GHA macOS/Ubuntu jobs with both architectures, and we will need to add some 3.12-dev coverage soonish. Not opposed to this PR, and I'm very much for increasing test coverage, but let's keep an eye on things so they stay manageable :) |
|
IMHO testing MINGW64 (GCC toolchain w/ legacy MSVCRT) and CLANG64 (LLVM toolchain w/ modern UCRT) should provide decent coverage if one is trying to reduce the number of jobs. There's little point in testing 32-bit, support for it is being phased out anyway... |
|
I've had a hardware issue preventing me from working on this until now...
I was going to suggest something similar to @kmilos's comment. I've now updated the test matrix to (and listed the others in a comment):
|
|
Any particular reason for not using the setup-msys2 action and all this extra manual work? |
|
IIRC this was made before the setup-msys2 action, and it seems like less work to just update it as is instead of switching to the setup-msys2 action. |
|
I think you'll find switching will pay off when it comes to flexibility and long term maintanance of these jobs. I might be able to help with this when I find some time. |
| mingw-w64-x86_64-python3 \ | ||
| mingw-w64-x86_64-python3-pip \ | ||
| mingw-w64-x86_64-python3-setuptools | ||
| mingw-w64-ucrt-x86_64-gcc \ |
| - ``mingw-w64-clang-x86_64`` | ||
| * - **MINGW64** | ||
| - ``mingw-w64-x86_64`` | ||
|
|
There was a problem hiding this comment.
Please add CLANGARM64 as well?
| * - **MINGW64** | ||
| - ``mingw-w64-x86_64`` | ||
|
|
||
| Installing in **MSYS2 MSYS** is not supported. | ||
|
|
||
| Make sure you have Python and GCC installed:: | ||
|
|
||
| pacman -S \ |
There was a problem hiding this comment.
Might be an idea to add --needed to all pacman commands to avoid reinstallation...
| * - **MINGW64** | ||
| - ``mingw-w64-x86_64`` | ||
|
|
||
| Installing in **MSYS2 MSYS** is not supported. | ||
|
|
||
| Make sure you have Python and GCC installed:: |
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| pacman -S --noconfirm \ |
| pactoys \ | ||
| subversion | ||
|
|
||
| pacboy -S --noconfirm \ |
|
|
||
| pacboy -S --noconfirm \ | ||
| freetype:p \ | ||
| gcc:p \ |
| python3-pip:p \ | ||
| python-pyqt6:p | ||
|
|
||
| python3 -m pip install pyroma pytest pytest-cov pytest-timeout |
There was a problem hiding this comment.
pytest, pytest-cov, and pytest-timeout can be (preferably?) installed by pacboy above
MSYS2 now has more environments: https://www.msys2.org/docs/environments/
Changes proposed in this pull request:
instead of MINGW32, GHA: Test MSYS2/CLANG64 #6888 (comment)Add xfail mark for Flaky test: test_qt_image_qapplication.py::test_sanity #6875 as it failed 9 times in a row.ciscripts simplifies it a bit.