Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiologic and culsans to Awesome Trio Libraries in the docs #3092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

x42005e1f
Copy link

Hi, I'd like to add aiologic to your list of awesome libraries. My library can be used to communicate with both threads and event loops in those threads, which can also be seen as an alternative approach to Trio/asyncio interoperability. But I'm not sure about which category aiologic is better to be in, so I put it under "Tools and Utilities". No documentation yet, but hopefully someone will find it useful.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (b834f73) to head (fea68b9).
Report is 167 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
+ Coverage   99.60%   99.63%   +0.02%     
==========================================
  Files         121      122       +1     
  Lines       17882    18380     +498     
  Branches     3214     1222    -1992     
==========================================
+ Hits        17811    18312     +501     
+ Misses         50       47       -3     
  Partials       21       21              

see 56 files with indirect coverage changes

@A5rocks
Copy link
Contributor

A5rocks commented Sep 22, 2024

I was looking at your README and it seems pretty nice! I don't think this is a good idea though:

Optional Trio-style checkpoints

If something is optional, that means there are no guarantees. And it's the guarantees that every await will call a checkpoint that make trio easier to use.

@x42005e1f
Copy link
Author

I agree @A5rocks, it does look weird, but the point is there: if a Trio run loop is running in a thread, then by default every await in that thread will call a checkpoint, otherwise it won't. This behavior can be changed via environment variables: you can even enable checkpoints for synchronous calls at the threading level (and get very nice fairness). It all depends on what the user wants.

@x42005e1f
Copy link
Author

Now, since the last commit, the above behavior is clarified in my README.

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though I'm not too sure about the summary. If you think that describes it best then good enough.

@x42005e1f x42005e1f changed the title Add aiologic to Awesome Trio Libraries in the docs Add aiologic and culsans to Awesome Trio Libraries in the docs Nov 3, 2024
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks good to me :P

I didn't merge this previously cause I wanted someone else to sanity check. But if nobody does I'll merge this eventually (not that soon though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants