-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiologic and culsans to Awesome Trio Libraries in the docs #3092
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3092 +/- ##
==========================================
+ Coverage 99.60% 99.63% +0.02%
==========================================
Files 121 122 +1
Lines 17882 18380 +498
Branches 3214 1222 -1992
==========================================
+ Hits 17811 18312 +501
+ Misses 50 47 -3
Partials 21 21 |
I was looking at your README and it seems pretty nice! I don't think this is a good idea though:
If something is optional, that means there are no guarantees. And it's the guarantees that every |
I agree @A5rocks, it does look weird, but the point is there: if a Trio run loop is running in a thread, then by default every |
Now, since the last commit, the above behavior is clarified in my README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, though I'm not too sure about the summary. If you think that describes it best then good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still looks good to me :P
I didn't merge this previously cause I wanted someone else to sanity check. But if nobody does I'll merge this eventually (not that soon though.)
Hi, I'd like to add aiologic to your list of awesome libraries. My library can be used to communicate with both threads and event loops in those threads, which can also be seen as an alternative approach to Trio/asyncio interoperability. But I'm not sure about which category aiologic is better to be in, so I put it under "Tools and Utilities". No documentation yet, but hopefully someone will find it useful.