Disallow cross-origin redirect when host, port, path or sock is set. (#631) #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en host, port or path is set. (python-websockets#631)
aaugustin
force-pushed
the
main
branch
2 times, most recently
from
dba135f to
e10eeba
Compare
aaugustin
force-pushed
the
main
branch
2 times, most recently
from
c760cdf to
5eafbe4
Compare
|
I'm not going to fix this in the legacy implementation. #1495 gets it right in the new asyncio implementation. It's also a bit smarter e.g. it supports same-origin redirects when host and port are overridden, which is OK. This PR breaks that use case, which could be considered as a regression by users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #631.