Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #359
Summarizing the needs from #358 (and from our previous calls)
we shouldn't use caching for install type requirements because we always want the latest version that matches the reqs and constraints and we cannot guarantee that the latest version will exist in the cache. For example:
numpy<2
which ends up populating the cache with saynumpy==1
. Then we want to resolvenumpy>=1
as an install type req. if we end up using the cache it would returnnumpy==1
even though there is anumpy==2
that we can use.the cache is something internal to the resolver and should not be influenced directly by the caller of the resolver