Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-85168: Use filesystem encoding when converting to/from file URIs #126852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-85168: Use filesystem encoding when converting to/from file URIs #126852

wants to merge 3 commits into from
+24 −10

Commits on Nov 15, 2024

  1. pythonGH-85168: Use filesystem encoding when converting to/from `file… 

    …` URIs

Adjust `urllib.request.url2pathname()` and `pathname2url()` to use the
filesystem encoding when quoting and unquoting file URIs, rather than
forcing use of UTF-8.

No changes are needed in the `nturl2path` module because Windows always
uses UTF-8, per PEP 529.
    @barneygale
    barneygale committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    11b9602 View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @barneygale
    barneygale committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a6f57d3 View commit details
    Browse the repository at this point in the history

  3. Undo unnecessary import

    @barneygale
    barneygale committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f123044 View commit details
    Browse the repository at this point in the history