Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30988: Add InvalidHeaderDefect for Trailing Periods #18687

Closed
wants to merge 3 commits into from

Conversation

malvidin
Copy link

@malvidin malvidin commented Feb 28, 2020

When an email header address field contains a period directly before the angle bracket, the default header policy raises an Attribute error, rather than adding a header defect.

This issue is referenced in the eml_parser as 27257, but I am not sure if this is the correct issue.
GOVCERT-LU/eml_parser#41

https://github.com/GOVCERT-LU/eml_parser/blob/f98980a77d9c7d914d97525a62294075c0ce42d9/tests/test_emlparser.py#L136

This was only checked with Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 21:26:53).

https://bugs.python.org/issue27257

When an email header address field contains a period directly before the angle bracket, the default header policy raises an Attribute error, rather than adding a header defect.

GOVCERT-LU/eml_parser#41
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@malvidin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #18687 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18687       +/-   ##
===========================================
+ Coverage   82.12%   83.21%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589830   415188   -174642     
  Branches    44477    44480        +3     
===========================================
- Hits       484427   345506   -138921     
+ Misses      95752    60035    -35717     
+ Partials     9651     9647        -4     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a4d57...effa92a. Read the comment docs.

@malvidin
Copy link
Author

malvidin commented Mar 3, 2020

Changed to bpo-30988, which appears to be more related than the bpo-27257 mentioned in the eml_parser.

This change does not raise errors on leading or trailing dots on obsolete email headers. 
The previous modification in the get_phrase function only worked on the trailing dot issue.
@malvidin
Copy link
Author

malvidin commented Mar 3, 2020

Looking through bug tracker, it appears that 30988 should be the bug referenced in the eml_parser.
https://bugs.python.org/issue30988

@malvidin malvidin changed the title bpo-27257: Add InvalidHeaderDefect for Trailing Periods bpo-30988: Add InvalidHeaderDefect for Trailing Periods Mar 3, 2020
@malvidin
Copy link
Author

malvidin commented Mar 4, 2020

Duplicate of #15600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants