New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a function to search for pyproject.toml in a project root #16965

Merged

ilevkivskyi merged 3 commits into python:master from Felixoid:master

Jan 16, 2025

Contributor

Felixoid commented Feb 29, 2024 •

edited

Loading

(Explain how this PR changes mypy.)

Here's a solution to fix #10613. The tests are covered.

It adds the functionality of searching pyproject.toml recursively from the current directory up to a project root (directory with either .git or .hg) to mypy

Felixoid mentioned this pull request

mypy should search parent directories for pyproject.toml config file #10613

Closed

This comment has been minimized.

Sign in to view

Felixoid force-pushed the master branch 2 times, most recently from add2786 to 65324b8 Compare

February 29, 2024 19:49

This comment has been minimized.

Sign in to view

Felixoid force-pushed the master branch from f4e0e40 to 5e7c1ad Compare

February 29, 2024 23:44

This comment has been minimized.

Sign in to view

Felixoid force-pushed the master branch 2 times, most recently from d04de61 to 70f00d6 Compare

March 1, 2024 00:06

This comment has been minimized.

Sign in to view

Felixoid force-pushed the master branch from 70f00d6 to f4890a9 Compare

March 1, 2024 01:25

Felixoid marked this pull request as ready for review

March 1, 2024 01:26

This comment has been minimized.

Sign in to view

Felixoid force-pushed the master branch from f4890a9 to b1a7100 Compare

March 1, 2024 09:42

This comment has been minimized.

Sign in to view

Contributor Author

Felixoid commented Mar 5, 2024

dear @ilevkivskyi, can you take a look, please?

Contributor Author

Felixoid commented Mar 21, 2024

Maybe, dear @JukkaL, @hauntsaninja, or @sobolevn could kindly take a look?

Contributor Author

Felixoid commented Jul 31, 2024

please, any feedback?

Contributor Author

Felixoid commented Jan 15, 2025

Hello? Could the PR be reviewed, please?

Dear @JukkaL, @hauntsaninja, @cdce8p, or @sobolevn?

Member

sobolevn commented Jan 15, 2025

Sorry, I don't have context of this PR, so I cannot review :(

Contributor Author

Felixoid commented Jan 15, 2025

Issue #10613 describes it. I've also changed the PR body. I'd really appreciate it; having the [tool.mypy] section in a single place adds a lot of value. 🙏

Felixoid added 3 commits

January 15, 2025 12:28


          Add a function to search for pyproject.toml in a project root

795c8bd


          Find pyproject.toml only once, and use it in CONFIG_FILES

55a2145


          Add a test for reading pyproject.toml recursively

c861c57

Felixoid force-pushed the master branch from b1a7100 to c861c57 Compare

January 15, 2025 11:29

Contributor Author

Felixoid commented Jan 15, 2025

rebased it on the most recent upstream

Contributor

github-actions bot commented Jan 15, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

ilevkivskyi approved these changes

View reviewed changes

Member

ilevkivskyi left a comment

I am not a big expert on pyproject.toml and don't know how it works in other tools. But I don't see anything obviously wrong in this PR, so let's try it.

ilevkivskyi merged commit 55a8840 into python:master

18 checks passed

Contributor Author

Felixoid commented Jan 17, 2025

Oh, great! Thanks a lot!

I'll prepare the docs update PR then, so people can start use it

hauntsaninja mentioned this pull request

Walk up for all config files and handle precedence #18482

Merged

Collaborator

hauntsaninja commented Jan 17, 2025 •

edited

Loading

This doesn't handle precedence correctly / doesn't handle other mypy configuration files. What do you think of #18482 ?

hauntsaninja added a commit that referenced this pull request


          Walk up for all config files and handle precedence (#18482)

42a97bb

Follow up to #16965
Fixes #16070

Handles other mypy configuration files and handles precedence between
them. Also fixes few small things, like use in git worktrees

wesleywright pushed a commit that referenced this pull request


          Walk up for all config files and handle precedence (#18482)

33f60e4

Follow up to #16965
Fixes #16070

Handles other mypy configuration files and handles precedence between
them. Also fixes few small things, like use in git worktrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet