Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stdlib stubtest for latest Python patch releases #13464

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Fix stdlib stubtest for latest Python patch releases #13464

merged 6 commits into from
Feb 5, 2025

Conversation

AlexWaygood
Copy link
Member

I noticed the daily test was about to fail this evening due to some of the changes in the new patch releases for Python 3.12 and 3.13

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Feb 5, 2025 •
edited
Loading

socket.SO_BINDTODEVICE seems like it was available on Python 3.13/Darwin between December 5th (see #13196) and February 4th inclusive... no idea why. It's not available for me locally either (and not documented as being available on Darwin, I don't think?), so I've removed it from the stub again.

AlexWaygood
AlexWaygood commented Feb 5, 2025
View reviewed changes
stdlib/email/_header_value_parser.pyi
@@ -21,6 +22,9 @@ NLSET: Final[set[str]]
# Added in Python 3.8.20, 3.9.20, 3.10.15, 3.11.10, 3.12.5
SPECIALSNL: Final[set[str]]

if sys.version_info >= (3, 12):
def make_quoted_pairs(value: Any) -> str: ...
Copy link
Member Author

@AlexWaygood AlexWaygood Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave this the same signature as quote_string below, since quote_string directly calls make_quoted_pairs now: https://github.com/python/cpython/blob/58a4357e29a15135e6fd99f320c60f8ea0472d27/Lib/email/_header_value_parser.py#L99-L106

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member Author

Just going to merge so the daily test doesn't fail in half an hour, but it anybody has any post-merge review comments I'm happy to tackle them in a followup PR!

@AlexWaygood AlexWaygood merged commit 5caaf2e into main Feb 5, 2025
55 checks passed
@AlexWaygood AlexWaygood deleted the alex/new-pythons branch February 5, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexWaygood