Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lora/model combo preview #423

Merged

Conversation

christian-byrne
Copy link
Contributor

This PR resolves #413 by updating the lora/model combo preview to work with Comfy-Org/litegraph.js#414.

Changes include:

  • Use constant for width/height of preview image
  • Attach image preview to body instead of the context menu directly, as the context menu no longer shows overflow
  • Add mouseenter, mouseleave, and click handlers to manually calculate and update the position/visibility of the preview image

@Piscabo
Copy link

Piscabo commented Feb 1, 2025

Thank heavens, this took forever. I was lost without it! I mean it is the main feature to see thumbs of what you have... Thank you! But after several tries... I still don't have lora thumbnails. So I give up on this node...

@christian-byrne
Copy link
Contributor Author

christian-byrne commented Feb 2, 2025

Thank heavens, this took forever. I was lost without it! I mean it is the main feature to see thumbs of what you have... Thank you! But after several tries... I still don't have lora thumbnails. So I give up on this node...

If you can provide browser and terminal logs and/or reproduction steps, I can try to help you fix it.

There is also an alternative for viewing thumbs of models/loras. You can use the models sidebar tab to choose model/lora, which should also display thumbs. Then, to use a model/lora, you can click and drag the item from the sidebar onto an existing loader node or onto a blank spot on the canvas and a loader node will be created automatically.

@christian-byrne christian-byrne deleted the loader-preview-fix branch February 2, 2025 21:34
@Piscabo
Copy link

Piscabo commented Feb 3, 2025

Thank heavens, this took forever. I was lost without it! I mean it is the main feature to see thumbs of what you have... Thank you! But after several tries... I still don't have lora thumbnails. So I give up on this node...

If you can provide browser and terminal logs and/or reproduction steps, I can try to help you fix it.

There is also an alternative for viewing thumbs of models/loras. You can use the models sidebar tab to choose model/lora, which should also display thumbs. Then, to use a model/lora, you can click and drag the item from the sidebar onto an existing loader node or onto a blank spot on the canvas and a loader node will be created automatically.

Thankyou for offring to help. I really appreciate this. As you can see from the image I don't even have thumbs on the sidebar method you mention :-(
image
I' don't know where the logs are that you refer to?

@christian-byrne
Copy link
Contributor Author

Happy to help. Just to verify, you do have the images in the same folder as the models with matching names correct?

By logs, I just mean if there are any errors in the terminal window you start ComfyUI with or in the browser console (F12 to show).

@Piscabo
Copy link

Piscabo commented Feb 3, 2025

Happy to help. Just to verify, you do have the images in the same folder as the models with matching names correct?

By logs, I just mean if there are any errors in the terminal window you start ComfyUI with or in the browser console (F12 to show).
Little to no errors in terminal window, but there is stuff in console. Don't know if it is related.
Images was pulled through the node, so yeah all correct in that way. Everything worked fine till recently.
image
Errors in log are these, but all nodes load without a problem:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly, the loader does not display the thumbnail image.
3 participants