Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added HTML and CSS and JS for dark Mode button #347

Merged

Conversation

avinashsharma080
Copy link
Contributor

Description

Fix #336

Added HTML , CSS and Javascript for the dark mode theme toggle for CodeGenerator Webpage

Additional context

Javascript seems to respond to the button click but theme isn't changing


What is the purpose of this pull request?

To submit initial PR so that later I can take more task later once get more familiarity with this repo

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for code-generator ready!

Name Link
🔨 Latest commit 73f138b
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/65d223d8a290330008aec443
😎 Deploy Preview https://deploy-preview-347--code-generator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vfdev-5 vfdev-5 marked this pull request as draft January 15, 2024 10:11
@avinashsharma080 avinashsharma080 marked this pull request as ready for review January 15, 2024 10:12
@vfdev-5 vfdev-5 marked this pull request as draft January 15, 2024 10:13
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@vfdev-5
Copy link
Member

vfdev-5 commented Jan 25, 2024

@avinashsharma080 avinashsharma080 marked this pull request as ready for review February 12, 2024 06:17
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the PR @avinashsharma080 !

@vfdev-5 vfdev-5 merged commit f7fd288 into pytorch-ignite:main Feb 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode for the Code Generator App
2 participants