-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Triton based GroupedGEMM implementation. #3674
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D69364390 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
levendlee
added a commit
to levendlee/FBGEMM
that referenced
this pull request
Feb 11, 2025
Summary: X-link: facebookresearch/FBGEMM#751 Adds triton based grouped gemm implementation with on-device shape information. - This implementation limits N and K must be consistent but M can be different across all groups. - Shape annotation: A: [M, K]; B: [N * G, K]; C: [M, N]. Noted G indicates number of groups. This moves experimental code from D69334734 to production. Besides, - It is added as a standalone module to avoid breaking other production moduels. - It doesn't have a benchmark attached to avoid leak confidential information to OSS. Reviewed By: jwfromm Differential Revision: D69364390
610f559
to
3c79fa9
Compare
This pull request was exported from Phabricator. Differential Revision: D69364390 |
Summary: X-link: facebookresearch/FBGEMM#751 Adds triton based grouped gemm implementation with on-device shape information. - This implementation limits N and K must be consistent but M can be different across all groups. - Shape annotation: A: [M, K]; B: [N * G, K]; C: [M, N]. Noted G indicates number of groups. This moves experimental code from D69334734 to production. Besides, - It is added as a standalone module to avoid breaking other production moduels. - It doesn't have a benchmark attached to avoid leak confidential information to OSS. Reviewed By: jwfromm Differential Revision: D69364390
3c79fa9
to
49890c5
Compare
This pull request was exported from Phabricator. Differential Revision: D69364390 |
This pull request has been merged in 0c2b7a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/751
Adds triton based grouped gemm implementation with on-device shape information.
This moves experimental code from D69334734 to production.
Besides,
Differential Revision: D69364390