Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Triton based GroupedGEMM implementation. #3674

Closed
wants to merge 1 commit into from

Conversation

levendlee
Copy link
Member

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/751

Adds triton based grouped gemm implementation with on-device shape information.

  • This implementation limits N and K must be consistent but M can be different across all groups.
  • Shape annotation: A: [M, K]; B: [N * G, K]; C: [M, N]. Noted G indicates number of groups.

This moves experimental code from D69334734 to production.

Besides,

  • It is added as a standalone module to avoid breaking other production moduels.
  • It doesn't have a benchmark attached to avoid leak confidential information to OSS.

Differential Revision: D69364390

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69364390

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 49890c5
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67abb740ad5923000878e184
😎 Deploy Preview https://deploy-preview-3674--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

levendlee added a commit to levendlee/FBGEMM that referenced this pull request Feb 11, 2025
Summary:

X-link: facebookresearch/FBGEMM#751

Adds triton based grouped gemm implementation with on-device shape information. 
- This implementation limits N and K must be consistent but M can be different across all groups.
- Shape annotation: A: [M, K]; B: [N * G, K]; C: [M, N]. Noted G indicates number of groups.

This moves experimental code from D69334734 to production.

Besides,
- It is added as a standalone module to avoid breaking other production moduels.
- It doesn't have a benchmark attached to avoid leak confidential information to OSS.

Reviewed By: jwfromm

Differential Revision: D69364390
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69364390

Summary:

X-link: facebookresearch/FBGEMM#751

Adds triton based grouped gemm implementation with on-device shape information. 
- This implementation limits N and K must be consistent but M can be different across all groups.
- Shape annotation: A: [M, K]; B: [N * G, K]; C: [M, N]. Noted G indicates number of groups.

This moves experimental code from D69334734 to production.

Besides,
- It is added as a standalone module to avoid breaking other production moduels.
- It doesn't have a benchmark attached to avoid leak confidential information to OSS.

Reviewed By: jwfromm

Differential Revision: D69364390
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69364390

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0c2b7a1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants