Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate weight_norm #3523

Closed
wants to merge 2 commits into from
Closed

Migrate weight_norm #3523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75fb860
Update weight_norm
mthrok Jul 31, 2023
4a5cdc0
fix
mthrok Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions torchaudio/models/wav2vec2/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,18 +208,13 @@ def __init__(
groups=groups,
)

self.conv = nn.utils.weight_norm(self.conv, name="weight", dim=2)
self.conv = nn.utils.parametrizations.weight_norm(self.conv, name="weight", dim=2)
self.num_remove: int = 1 if kernel_size % 2 == 0 else 0

def __prepare_scriptable__(self):
for hook in self.conv._forward_pre_hooks.values():
# The hook we want to remove is an instance of WeightNorm class, so
# normally we would do `if isinstance(...)` but this class is not accessible
# because of shadowing, so we check the module name directly.
# https://github.com/pytorch/pytorch/blob/be0ca00c5ce260eb5bcec3237357f7a30cc08983/torch/nn/utils/__init__.py#L3
if hook.__module__ == "torch.nn.utils.weight_norm" and hook.__class__.__name__ == "WeightNorm":
_LG.warning("Removing weight_norm from %s", self.__class__.__name__)
torch.nn.utils.remove_weight_norm(self.conv)
if self.conv.__class__.__name__ == "ParametrizedConv1d":
_LG.warning("Removing weight_norm from %s", self.__class__.__name__)
torch.nn.utils.parametrize.remove_parametrizations(self.conv, "weight")
return self

def forward(self, x):
Expand Down
Loading