FullyBayesianSingleTaskGP.train should not return None #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is for consistency with the signature of `Module.train`. Differential Revision: D68710923
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68710923 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2702 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 200 200
Lines 18365 18367 +2
=======================================
+ Hits 18363 18365 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jan 27, 2025
Summary: This is for consistency with the signature of `Module.train`. Reviewed By: saitcakmak, Balandat Differential Revision: D68710923
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jan 27, 2025
Summary: This made it easier for me to check if there were any other issues like pytorch#2702. Brings BoTorch down from 10275 to 10254 type errors Differential Revision: D68711505
|
This pull request has been merged in 81155da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is for consistency with the signature of
Module.train.Differential Revision: D68710923