Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix conda env issue on MPS tests #3148

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Try to fix conda env issue on MPS tests #3148

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
955ed5e
Try to fix conda env issue on MPS tests
vfdev-5 Nov 24, 2023
740f5f4
another try
vfdev-5 Nov 24, 2023
0ec7e2d
another attempt
vfdev-5 Nov 24, 2023
4ab1f4b
attempt 4
vfdev-5 Nov 24, 2023
bf8413e
attempt 5
vfdev-5 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/mps-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

# Cherry-picked from
# - https://github.com/pytorch/vision/main/.github/workflows/tests.yml
# - https://github.com/pytorch/vision/blob/main/.github/workflows/tests.yml
# - https://github.com/pytorch/test-infra/blob/main/.github/workflows/macos_job.yml

jobs:
Expand Down Expand Up @@ -73,17 +73,24 @@ jobs:
- name: Install PyTorch
if: ${{ matrix.pytorch-channel == 'pytorch' }}
shell: bash -l {0}
run: pip install torch torchvision
run: |
conda shell.bash hook
conda activate $CONDA_ENV
pip install torch torchvision

- name: Install PyTorch (nightly)
if: ${{ matrix.pytorch-channel == 'pytorch-nightly' }}
shell: bash -l {0}
run: pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu
run: |
conda shell.bash hook
conda activate $CONDA_ENV
pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu

- name: Install dependencies
shell: bash -l {0}
working-directory: ${{ github.repository }}
run: |
conda activate $CONDA_ENV
# TODO: We add set -xe to explicitly fail the CI if one of the commands is failing.
# Somehow the step is passing even if a subcommand failed
set -xe
Expand All @@ -110,6 +117,7 @@ jobs:
shell: bash -l {0}
working-directory: ${{ github.repository }}
run: |
conda activate $CONDA_ENV
SKIP_DISTRIB_TESTS=${{ matrix.skip-distrib-tests }} bash tests/run_cpu_tests.sh

- name: Upload coverage to Codecov
Expand All @@ -122,4 +130,6 @@ jobs:
- name: Run MNIST Examples
shell: bash -l {0}
working-directory: ${{ github.repository }}
run: python examples/mnist/mnist.py --epochs=1
run: |
conda activate $CONDA_ENV
python examples/mnist/mnist.py --epochs=1