-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PearsonCorrelation metric #3212
Conversation
@kzkadc thanks for the PR, I haven't yet reviewed it in details, just a remark on the code location which could be better to be at |
@vfdev-5 Is it better to create |
@kzkadc yes, we'll move all ignite.contrib.metrics into ignite.metrics very soon, so I'd say let's just update your PR such that the metric is in ignite.metrics but we are using |
Please also fix code formatting issue https://github.com/pytorch/ignite/actions/runs/8469886156/job/23234585039?pr=3212
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this PR, @kzkadc !
Let's see if CI is globally passing the tests and it would be good to land it
Head branch was pushed to by a user without write access
@kzkadc can you please fix the issue with the implementation using non-cpu device:
https://github.com/pytorch/ignite/actions/runs/8490646759/job/23261938233#step:9:904 |
Description: added Pearson correlation coefficient metric to
ignite.contrib.metrics.regression
.Check list: