Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix minari #2078

Closed
wants to merge 3 commits into from
Closed

[BugFix] Fix minari #2078

wants to merge 3 commits into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 15, 2024

No description provided.

vmoens added 2 commits April 15, 2024 11:26
Copy link

pytorch-bot bot commented Apr 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2078

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 4 Unrelated Failures

As of commit 3399784 with merge base 0d00748 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@vmoens vmoens added the Data Data-related PR, will launch data-related jobs label Apr 15, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

'&' can not be used here

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$
Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: 11 . Worsened: 2 .

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 52.5749ms 51.5445ms 19.4007 Ops/s 17.7512 Ops/s +9.29%
test_sync 35.3389ms 31.7667ms 31.4795 Ops/s 29.9617 Ops/s +5.07%
test_async 55.8450ms 26.2925ms 38.0336 Ops/s 36.6548 Ops/s + 3.76 %
test_simple 0.3318s 0.3301s 3.0292 Ops/s 2.9675 Ops/s + 2.08 %
test_transformed 0.4752s 0.4713s 2.1217 Ops/s 1.9833 Ops/s +6.98%
test_serial 1.2301s 1.1740s 0.8518 Ops/s 0.8326 Ops/s + 2.31 %
test_parallel 1.0369s 0.9845s 1.0157 Ops/s 1.0000 Ops/s + 1.57 %
test_step_mdp_speed[True-True-True-True-True] 0.1853ms 21.0332μs 47.5438 KOps/s 47.6174 KOps/s 0.15 %
test_step_mdp_speed[True-True-True-True-False] 42.1390μs 12.7767μs 78.2675 KOps/s 77.3790 KOps/s + 1.15 %
test_step_mdp_speed[True-True-True-False-True] 37.0490μs 12.3262μs 81.1280 KOps/s 80.2627 KOps/s + 1.08 %
test_step_mdp_speed[True-True-True-False-False] 35.1160μs 7.4396μs 134.4155 KOps/s 132.4485 KOps/s + 1.49 %
test_step_mdp_speed[True-True-False-True-True] 48.5310μs 22.2610μs 44.9217 KOps/s 44.3708 KOps/s + 1.24 %
test_step_mdp_speed[True-True-False-True-False] 35.5470μs 13.9135μs 71.8727 KOps/s 70.7835 KOps/s + 1.54 %
test_step_mdp_speed[True-True-False-False-True] 62.2770μs 13.5978μs 73.5414 KOps/s 73.9042 KOps/s 0.49 %
test_step_mdp_speed[True-True-False-False-False] 29.6360μs 8.5472μs 116.9975 KOps/s 114.6824 KOps/s + 2.02 %
test_step_mdp_speed[True-False-True-True-True] 67.9570μs 23.7058μs 42.1837 KOps/s 42.1074 KOps/s + 0.18 %
test_step_mdp_speed[True-False-True-True-False] 40.4560μs 15.2685μs 65.4944 KOps/s 64.9172 KOps/s + 0.89 %
test_step_mdp_speed[True-False-True-False-True] 44.6430μs 13.5299μs 73.9104 KOps/s 73.9802 KOps/s 0.09 %
test_step_mdp_speed[True-False-True-False-False] 43.4710μs 8.5934μs 116.3685 KOps/s 113.4744 KOps/s + 2.55 %
test_step_mdp_speed[True-False-False-True-True] 85.2200μs 24.7987μs 40.3248 KOps/s 39.5165 KOps/s + 2.05 %
test_step_mdp_speed[True-False-False-True-False] 44.4040μs 16.3714μs 61.0823 KOps/s 60.9567 KOps/s + 0.21 %
test_step_mdp_speed[True-False-False-False-True] 47.7590μs 14.6287μs 68.3589 KOps/s 67.8914 KOps/s + 0.69 %
test_step_mdp_speed[True-False-False-False-False] 30.0970μs 9.7336μs 102.7373 KOps/s 99.2354 KOps/s + 3.53 %
test_step_mdp_speed[False-True-True-True-True] 75.0900μs 23.5116μs 42.5322 KOps/s 42.2183 KOps/s + 0.74 %
test_step_mdp_speed[False-True-True-True-False] 55.0130μs 15.4000μs 64.9353 KOps/s 64.6323 KOps/s + 0.47 %
test_step_mdp_speed[False-True-True-False-True] 48.9310μs 15.6604μs 63.8555 KOps/s 62.3541 KOps/s + 2.41 %
test_step_mdp_speed[False-True-True-False-False] 32.0400μs 9.8558μs 101.4632 KOps/s 100.9132 KOps/s + 0.55 %
test_step_mdp_speed[False-True-False-True-True] 39.5040μs 25.1815μs 39.7118 KOps/s 39.8727 KOps/s 0.40 %
test_step_mdp_speed[False-True-False-True-False] 46.3870μs 16.4564μs 60.7665 KOps/s 60.1699 KOps/s + 0.99 %
test_step_mdp_speed[False-True-False-False-True] 45.6050μs 16.8214μs 59.4482 KOps/s 58.8931 KOps/s + 0.94 %
test_step_mdp_speed[False-True-False-False-False] 43.3110μs 10.9680μs 91.1744 KOps/s 89.3071 KOps/s + 2.09 %
test_step_mdp_speed[False-False-True-True-True] 61.1250μs 26.1904μs 38.1819 KOps/s 38.5642 KOps/s 0.99 %
test_step_mdp_speed[False-False-True-True-False] 56.3960μs 17.5908μs 56.8479 KOps/s 55.7440 KOps/s + 1.98 %
test_step_mdp_speed[False-False-True-False-True] 68.0580μs 16.8860μs 59.2206 KOps/s 59.0327 KOps/s + 0.32 %
test_step_mdp_speed[False-False-True-False-False] 46.7780μs 10.9526μs 91.3021 KOps/s 90.5797 KOps/s + 0.80 %
test_step_mdp_speed[False-False-False-True-True] 61.1850μs 26.8665μs 37.2210 KOps/s 36.7888 KOps/s + 1.17 %
test_step_mdp_speed[False-False-False-True-False] 42.1890μs 18.5713μs 53.8466 KOps/s 52.8863 KOps/s + 1.82 %
test_step_mdp_speed[False-False-False-False-True] 73.1970μs 17.7533μs 56.3276 KOps/s 55.7254 KOps/s + 1.08 %
test_step_mdp_speed[False-False-False-False-False] 40.8860μs 11.9174μs 83.9108 KOps/s 82.0952 KOps/s + 2.21 %
test_values[generalized_advantage_estimate-True-True] 9.4201ms 9.1449ms 109.3500 Ops/s 107.4134 Ops/s + 1.80 %
test_values[vec_generalized_advantage_estimate-True-True] 38.0735ms 33.5593ms 29.7980 Ops/s 29.3488 Ops/s + 1.53 %
test_values[td0_return_estimate-False-False] 0.2169ms 0.1689ms 5.9197 KOps/s 5.8770 KOps/s + 0.73 %
test_values[td1_return_estimate-False-False] 25.8974ms 22.8202ms 43.8209 Ops/s 43.2829 Ops/s + 1.24 %
test_values[vec_td1_return_estimate-False-False] 34.8144ms 33.6490ms 29.7186 Ops/s 29.6898 Ops/s + 0.10 %
test_values[td_lambda_return_estimate-True-False] 33.1578ms 32.7849ms 30.5019 Ops/s 30.1517 Ops/s + 1.16 %
test_values[vec_td_lambda_return_estimate-True-False] 35.0203ms 33.6918ms 29.6808 Ops/s 29.7445 Ops/s 0.21 %
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2062ms 7.9948ms 125.0806 Ops/s 124.4856 Ops/s + 0.48 %
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3989ms 1.9898ms 502.5514 Ops/s 518.2204 Ops/s 3.02 %
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5317ms 0.3462ms 2.8887 KOps/s 2.8521 KOps/s + 1.28 %
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 45.6589ms 43.6596ms 22.9045 Ops/s 24.4375 Ops/s -6.27%
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7645ms 3.0435ms 328.5727 Ops/s 327.3973 Ops/s + 0.36 %
test_dqn_speed 6.7400ms 1.3278ms 753.1206 Ops/s 732.0849 Ops/s + 2.87 %
test_ddpg_speed 3.3933ms 2.6731ms 374.1020 Ops/s 364.8078 Ops/s + 2.55 %
test_sac_speed 13.3289ms 8.4132ms 118.8603 Ops/s 120.3422 Ops/s 1.23 %
test_redq_speed 14.9883ms 13.2582ms 75.4252 Ops/s 74.3826 Ops/s + 1.40 %
test_redq_deprec_speed 14.4515ms 13.3777ms 74.7515 Ops/s 70.0706 Ops/s +6.68%
test_td3_speed 8.4945ms 8.1047ms 123.3845 Ops/s 113.6381 Ops/s +8.58%
test_cql_speed 37.7184ms 36.2848ms 27.5597 Ops/s 25.3204 Ops/s +8.84%
test_a2c_speed 8.1174ms 7.4951ms 133.4203 Ops/s 124.2111 Ops/s +7.41%
test_ppo_speed 9.1253ms 7.7456ms 129.1050 Ops/s 119.5886 Ops/s +7.96%
test_reinforce_speed 7.4591ms 6.5766ms 152.0548 Ops/s 142.3039 Ops/s +6.85%
test_iql_speed 34.1055ms 32.5981ms 30.6766 Ops/s 29.6181 Ops/s + 3.57 %
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5752ms 2.3359ms 428.1050 Ops/s 396.7625 Ops/s +7.90%
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0408ms 0.5332ms 1.8754 KOps/s 1.9552 KOps/s 4.09 %
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7260ms 0.4794ms 2.0860 KOps/s 2.0324 KOps/s + 2.64 %
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0990ms 2.4460ms 408.8321 Ops/s 416.3694 Ops/s 1.81 %
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1257ms 0.4967ms 2.0134 KOps/s 1.9786 KOps/s + 1.76 %
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8630ms 0.4806ms 2.0808 KOps/s 2.0775 KOps/s + 0.16 %
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7267ms 1.2040ms 830.5705 Ops/s 818.3197 Ops/s + 1.50 %
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6330ms 1.1404ms 876.8854 Ops/s 860.0120 Ops/s + 1.96 %
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8369ms 2.5049ms 399.2130 Ops/s 395.7645 Ops/s + 0.87 %
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0789ms 0.6242ms 1.6020 KOps/s 1.5942 KOps/s + 0.49 %
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9763ms 0.6017ms 1.6621 KOps/s 1.6462 KOps/s + 0.96 %
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6493ms 2.3453ms 426.3773 Ops/s 416.0325 Ops/s + 2.49 %
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9900ms 0.5067ms 1.9736 KOps/s 1.9752 KOps/s 0.08 %
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5641ms 0.4773ms 2.0950 KOps/s 2.0047 KOps/s + 4.51 %
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7486ms 2.4169ms 413.7596 Ops/s 416.7553 Ops/s 0.72 %
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8009ms 0.5047ms 1.9815 KOps/s 1.9900 KOps/s 0.43 %
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6165ms 0.4742ms 2.1088 KOps/s 2.0920 KOps/s + 0.80 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7316ms 2.4825ms 402.8175 Ops/s 403.5428 Ops/s 0.18 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1791ms 0.6212ms 1.6099 KOps/s 1.5746 KOps/s + 2.24 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8465ms 0.6045ms 1.6543 KOps/s 1.6466 KOps/s + 0.46 %
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1179s 7.9724ms 125.4324 Ops/s 123.7566 Ops/s + 1.35 %
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.3005ms 12.1716ms 82.1588 Ops/s 81.7332 Ops/s + 0.52 %
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.5569ms 1.0277ms 973.0535 Ops/s 967.0380 Ops/s + 0.62 %
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1126s 5.7806ms 172.9938 Ops/s 124.1474 Ops/s +39.35%
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1162s 14.2354ms 70.2476 Ops/s 81.2665 Ops/s -13.56%
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6990ms 1.0251ms 975.4676 Ops/s 979.2265 Ops/s 0.38 %
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1138s 6.2194ms 160.7883 Ops/s 162.7906 Ops/s 1.23 %
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4615ms 12.5229ms 79.8537 Ops/s 79.0659 Ops/s + 1.00 %
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8363ms 1.3304ms 751.6800 Ops/s 744.6177 Ops/s + 0.95 %

Copy link

'&' can not be used here

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$
Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: 1 . Worsened: 5 .

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1009s 0.1002s 9.9788 Ops/s 10.1259 Ops/s 1.45 %
test_sync 88.3679ms 86.7876ms 11.5224 Ops/s 11.4313 Ops/s + 0.80 %
test_async 0.1664s 71.8927ms 13.9096 Ops/s 14.2900 Ops/s 2.66 %
test_single_pixels 0.1822s 0.1173s 8.5226 Ops/s 9.1611 Ops/s -6.97%
test_sync_pixels 67.1195ms 65.3407ms 15.3044 Ops/s 15.1766 Ops/s + 0.84 %
test_async_pixels 0.1212s 55.2902ms 18.0864 Ops/s 17.9235 Ops/s + 0.91 %
test_simple 0.6645s 0.6637s 1.5066 Ops/s 1.4646 Ops/s + 2.87 %
test_transformed 0.8904s 0.8898s 1.1238 Ops/s 1.1190 Ops/s + 0.43 %
test_serial 2.1262s 2.0680s 0.4836 Ops/s 0.4850 Ops/s 0.31 %
test_parallel 1.8551s 1.7846s 0.5603 Ops/s 0.5496 Ops/s + 1.95 %
test_step_mdp_speed[True-True-True-True-True] 90.0550μs 31.9255μs 31.3230 KOps/s 30.4564 KOps/s + 2.85 %
test_step_mdp_speed[True-True-True-True-False] 42.7320μs 18.9323μs 52.8199 KOps/s 51.0852 KOps/s + 3.40 %
test_step_mdp_speed[True-True-True-False-True] 41.8630μs 17.9416μs 55.7365 KOps/s 54.4972 KOps/s + 2.27 %
test_step_mdp_speed[True-True-True-False-False] 40.6830μs 10.8597μs 92.0835 KOps/s 89.3273 KOps/s + 3.09 %
test_step_mdp_speed[True-True-False-True-True] 63.4330μs 33.5252μs 29.8283 KOps/s 28.9434 KOps/s + 3.06 %
test_step_mdp_speed[True-True-False-True-False] 43.7830μs 20.7020μs 48.3045 KOps/s 46.8218 KOps/s + 3.17 %
test_step_mdp_speed[True-True-False-False-True] 47.6030μs 19.8652μs 50.3392 KOps/s 49.9032 KOps/s + 0.87 %
test_step_mdp_speed[True-True-False-False-False] 77.2440μs 12.6441μs 79.0885 KOps/s 76.7721 KOps/s + 3.02 %
test_step_mdp_speed[True-False-True-True-True] 79.6940μs 35.5512μs 28.1285 KOps/s 27.3540 KOps/s + 2.83 %
test_step_mdp_speed[True-False-True-True-False] 48.9730μs 22.7321μs 43.9907 KOps/s 42.9487 KOps/s + 2.43 %
test_step_mdp_speed[True-False-True-False-True] 44.5530μs 19.8559μs 50.3629 KOps/s 48.6999 KOps/s + 3.41 %
test_step_mdp_speed[True-False-True-False-False] 31.5310μs 12.7017μs 78.7297 KOps/s 77.5417 KOps/s + 1.53 %
test_step_mdp_speed[True-False-False-True-True] 70.8740μs 37.3268μs 26.7904 KOps/s 26.1824 KOps/s + 2.32 %
test_step_mdp_speed[True-False-False-True-False] 55.7730μs 24.3793μs 41.0184 KOps/s 39.8432 KOps/s + 2.95 %
test_step_mdp_speed[True-False-False-False-True] 48.5420μs 21.5459μs 46.4126 KOps/s 45.2818 KOps/s + 2.50 %
test_step_mdp_speed[True-False-False-False-False] 39.3220μs 14.3391μs 69.7395 KOps/s 67.8070 KOps/s + 2.85 %
test_step_mdp_speed[False-True-True-True-True] 91.9150μs 35.5486μs 28.1305 KOps/s 27.4450 KOps/s + 2.50 %
test_step_mdp_speed[False-True-True-True-False] 48.1820μs 22.6846μs 44.0828 KOps/s 42.9676 KOps/s + 2.60 %
test_step_mdp_speed[False-True-True-False-True] 68.7630μs 23.7191μs 42.1600 KOps/s 41.5575 KOps/s + 1.45 %
test_step_mdp_speed[False-True-True-False-False] 44.3630μs 14.4287μs 69.3063 KOps/s 68.7339 KOps/s + 0.83 %
test_step_mdp_speed[False-True-False-True-True] 63.9840μs 36.8703μs 27.1221 KOps/s 26.3082 KOps/s + 3.09 %
test_step_mdp_speed[False-True-False-True-False] 60.8940μs 24.2878μs 41.1729 KOps/s 39.6600 KOps/s + 3.81 %
test_step_mdp_speed[False-True-False-False-True] 56.7730μs 25.0268μs 39.9572 KOps/s 38.5366 KOps/s + 3.69 %
test_step_mdp_speed[False-True-False-False-False] 37.7720μs 16.1544μs 61.9025 KOps/s 60.5625 KOps/s + 2.21 %
test_step_mdp_speed[False-False-True-True-True] 79.8150μs 39.2176μs 25.4987 KOps/s 24.9346 KOps/s + 2.26 %
test_step_mdp_speed[False-False-True-True-False] 50.6330μs 26.3669μs 37.9264 KOps/s 37.1180 KOps/s + 2.18 %
test_step_mdp_speed[False-False-True-False-True] 49.2830μs 25.0992μs 39.8420 KOps/s 38.7404 KOps/s + 2.84 %
test_step_mdp_speed[False-False-True-False-False] 38.4820μs 16.1535μs 61.9060 KOps/s 60.0249 KOps/s + 3.13 %
test_step_mdp_speed[False-False-False-True-True] 74.1740μs 40.5021μs 24.6901 KOps/s 23.9648 KOps/s + 3.03 %
test_step_mdp_speed[False-False-False-True-False] 65.9340μs 28.0432μs 35.6593 KOps/s 34.6636 KOps/s + 2.87 %
test_step_mdp_speed[False-False-False-False-True] 55.8930μs 26.7787μs 37.3431 KOps/s 36.2930 KOps/s + 2.89 %
test_step_mdp_speed[False-False-False-False-False] 52.0330μs 17.8888μs 55.9009 KOps/s 53.4232 KOps/s + 4.64 %
test_values[generalized_advantage_estimate-True-True] 24.9010ms 24.2906ms 41.1681 Ops/s 41.7357 Ops/s 1.36 %
test_values[vec_generalized_advantage_estimate-True-True] 83.6411ms 3.2351ms 309.1126 Ops/s 299.6373 Ops/s + 3.16 %
test_values[td0_return_estimate-False-False] 93.1850μs 64.3105μs 15.5496 KOps/s 15.9318 KOps/s 2.40 %
test_values[td1_return_estimate-False-False] 53.9461ms 52.8467ms 18.9227 Ops/s 19.5209 Ops/s 3.06 %
test_values[vec_td1_return_estimate-False-False] 2.1225ms 1.7606ms 567.9960 Ops/s 571.1400 Ops/s 0.55 %
test_values[td_lambda_return_estimate-True-False] 84.6550ms 83.4883ms 11.9777 Ops/s 12.2850 Ops/s 2.50 %
test_values[vec_td_lambda_return_estimate-True-False] 2.0254ms 1.7491ms 571.7242 Ops/s 571.2672 Ops/s + 0.08 %
test_gae_speed[generalized_advantage_estimate-False-1-512] 22.6008ms 22.4188ms 44.6054 Ops/s 43.9506 Ops/s + 1.49 %
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8786ms 0.6898ms 1.4496 KOps/s 1.4496 KOps/s 0.00 %
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7186ms 0.6416ms 1.5587 KOps/s 1.5614 KOps/s 0.18 %
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4729ms 1.4410ms 693.9553 Ops/s 693.4946 Ops/s + 0.07 %
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9608ms 0.6645ms 1.5049 KOps/s 1.5041 KOps/s + 0.06 %
test_dqn_speed 3.9727ms 1.4412ms 693.8615 Ops/s 693.5851 Ops/s + 0.04 %
test_ddpg_speed 3.1030ms 2.7778ms 359.9913 Ops/s 362.0309 Ops/s 0.56 %
test_sac_speed 9.2898ms 8.2829ms 120.7306 Ops/s 124.0426 Ops/s 2.67 %
test_redq_speed 13.1222ms 10.7498ms 93.0253 Ops/s 94.2547 Ops/s 1.30 %
test_redq_deprec_speed 0.1015s 12.5175ms 79.8882 Ops/s 87.2926 Ops/s -8.48%
test_td3_speed 8.3841ms 8.3115ms 120.3153 Ops/s 125.2036 Ops/s 3.90 %
test_cql_speed 27.7596ms 26.5338ms 37.6878 Ops/s 38.6222 Ops/s 2.42 %
test_a2c_speed 6.4297ms 5.7466ms 174.0168 Ops/s 179.9713 Ops/s 3.31 %
test_ppo_speed 6.4414ms 6.0317ms 165.7896 Ops/s 171.7320 Ops/s 3.46 %
test_reinforce_speed 5.2454ms 4.7059ms 212.4984 Ops/s 215.1228 Ops/s 1.22 %
test_iql_speed 21.2701ms 20.3779ms 49.0728 Ops/s 49.6566 Ops/s 1.18 %
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0980ms 2.9700ms 336.6956 Ops/s 342.9153 Ops/s 1.81 %
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1045s 0.6394ms 1.5640 KOps/s 1.7862 KOps/s -12.44%
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7072ms 0.5417ms 1.8461 KOps/s 1.8655 KOps/s 1.04 %
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2325ms 2.9945ms 333.9434 Ops/s 341.4956 Ops/s 2.21 %
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.5031ms 0.5538ms 1.8057 KOps/s 1.8534 KOps/s 2.58 %
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6928ms 0.5297ms 1.8878 KOps/s 1.9398 KOps/s 2.68 %
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8292ms 1.4804ms 675.4956 Ops/s 702.4974 Ops/s 3.84 %
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6471ms 1.4670ms 681.6815 Ops/s 737.2530 Ops/s -7.54%
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2730ms 3.0933ms 323.2775 Ops/s 330.1456 Ops/s 2.08 %
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8403ms 0.7021ms 1.4243 KOps/s 1.4746 KOps/s 3.41 %
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.5251ms 0.6778ms 1.4754 KOps/s 1.5378 KOps/s 4.06 %
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0893ms 2.9763ms 335.9834 Ops/s 344.1331 Ops/s 2.37 %
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6954ms 0.5547ms 1.8029 KOps/s 1.8177 KOps/s 0.82 %
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.3900ms 0.5381ms 1.8583 KOps/s 1.8718 KOps/s 0.72 %
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1590ms 3.0222ms 330.8825 Ops/s 342.4265 Ops/s 3.37 %
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4534ms 0.5570ms 1.7952 KOps/s 1.8497 KOps/s 2.94 %
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7102ms 0.5272ms 1.8968 KOps/s 1.9433 KOps/s 2.39 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2226ms 3.0977ms 322.8150 Ops/s 329.4517 Ops/s 2.01 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8492ms 0.6974ms 1.4339 KOps/s 1.4789 KOps/s 3.04 %
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6052ms 0.6718ms 1.4886 KOps/s 1.5240 KOps/s 2.32 %
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1324s 9.7027ms 103.0642 Ops/s 105.0435 Ops/s 1.88 %
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.8881ms 14.4460ms 69.2234 Ops/s 70.3707 Ops/s 1.63 %
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.0962ms 1.1281ms 886.4387 Ops/s 934.5844 Ops/s -5.15%
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1175s 7.1270ms 140.3122 Ops/s 142.2399 Ops/s 1.36 %
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.5458ms 14.4457ms 69.2248 Ops/s 70.8824 Ops/s 2.34 %
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2590ms 1.1389ms 878.0513 Ops/s 914.4816 Ops/s 3.98 %
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1185s 7.5594ms 132.2860 Ops/s 102.9609 Ops/s +28.48%
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.2311ms 14.8208ms 67.4727 Ops/s 69.2065 Ops/s 2.51 %
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5707ms 1.4983ms 667.4116 Ops/s 698.5492 Ops/s 4.46 %

@vmoens vmoens closed this Apr 25, 2024
@vmoens vmoens deleted the fix-minari branch April 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants