Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix prints of size error when no file is associated with memmap #2090

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[BugFix] Fix prints of size error when no file is associated with memmap #2090

merged 1 commit into from
Apr 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 18, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2090

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 16 Unrelated Failures

As of commit a15fdc6 with merge base acf168e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@vmoens vmoens added bug Something isn't working quality code quality labels Apr 18, 2024
@vmoens vmoens merged commit 36c89dc into main Apr 18, 2024
22 of 37 checks passed
@vmoens vmoens deleted the fix-print-rb branch April 18, 2024 14:32
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 53.4762ms 52.7871ms 18.9440 Ops/s 18.0520 Ops/s $\color{#35bf28}+4.94\%$
test_sync 34.6143ms 29.4817ms 33.9194 Ops/s 34.2215 Ops/s $\color{#d91a1a}-0.88\%$
test_async 59.1405ms 26.8198ms 37.2859 Ops/s 35.9577 Ops/s $\color{#35bf28}+3.69\%$
test_simple 0.4114s 0.3487s 2.8680 Ops/s 3.0668 Ops/s $\textbf{\color{#d91a1a}-6.48\%}$
test_transformed 0.5600s 0.5019s 1.9925 Ops/s 2.0611 Ops/s $\color{#d91a1a}-3.33\%$
test_serial 1.2668s 1.2213s 0.8188 Ops/s 0.8521 Ops/s $\color{#d91a1a}-3.90\%$
test_parallel 1.0663s 1.0045s 0.9955 Ops/s 0.9983 Ops/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[True-True-True-True-True] 0.1430ms 21.5250μs 46.4576 KOps/s 46.8937 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-True-True-True-False] 44.5330μs 13.0425μs 76.6724 KOps/s 77.0428 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-True-False-True] 48.0130μs 12.6247μs 79.2099 KOps/s 79.9225 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[True-True-True-False-False] 32.7920μs 7.5813μs 131.9034 KOps/s 132.0965 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-True-False-True-True] 50.8360μs 22.8432μs 43.7766 KOps/s 43.9633 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[True-True-False-True-False] 39.2440μs 14.4800μs 69.0609 KOps/s 70.2855 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[True-True-False-False-True] 40.1850μs 13.7990μs 72.4690 KOps/s 73.0109 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[True-True-False-False-False] 33.8930μs 8.9270μs 112.0198 KOps/s 113.1651 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[True-False-True-True-True] 54.4220μs 24.0520μs 41.5766 KOps/s 40.9960 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-False-True-True-False] 39.9750μs 15.6822μs 63.7667 KOps/s 63.4059 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[True-False-True-False-True] 42.0990μs 13.8658μs 72.1198 KOps/s 72.7138 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[True-False-True-False-False] 59.3580μs 8.8830μs 112.5743 KOps/s 113.1888 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[True-False-False-True-True] 55.1930μs 25.3059μs 39.5164 KOps/s 39.3078 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[True-False-False-True-False] 45.7560μs 16.9604μs 58.9610 KOps/s 59.3698 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[True-False-False-False-True] 78.2900μs 14.8363μs 67.4023 KOps/s 67.7025 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-False-False-False-False] 33.5230μs 10.0462μs 99.5403 KOps/s 100.1020 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-True-True-True-True] 69.5810μs 24.1233μs 41.4537 KOps/s 41.6281 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-True-True-False] 44.1730μs 15.5693μs 64.2291 KOps/s 63.2789 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[False-True-True-False-True] 50.8650μs 16.0197μs 62.4232 KOps/s 62.3202 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[False-True-True-False-False] 42.2990μs 10.0760μs 99.2462 KOps/s 99.5172 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[False-True-False-True-True] 41.3870μs 25.5513μs 39.1370 KOps/s 38.8251 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-False-True-False] 45.1150μs 16.8173μs 59.4625 KOps/s 58.9028 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[False-True-False-False-True] 52.3280μs 17.1381μs 58.3495 KOps/s 58.1192 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-True-False-False-False] 41.0970μs 11.3879μs 87.8123 KOps/s 88.7814 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-False-True-True-True] 89.4380μs 26.4896μs 37.7506 KOps/s 37.7688 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-False-True-True-False] 61.6150μs 17.9684μs 55.6533 KOps/s 55.2903 KOps/s $\color{#35bf28}+0.66\%$
test_step_mdp_speed[False-False-True-False-True] 43.8620μs 17.1496μs 58.3103 KOps/s 58.0285 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[False-False-True-False-False] 34.1040μs 11.2998μs 88.4975 KOps/s 88.9387 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-False-False-True-True] 58.5090μs 27.7077μs 36.0910 KOps/s 36.3507 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-False-False-True-False] 48.2200μs 19.2066μs 52.0653 KOps/s 51.8565 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-False-False-False-True] 59.6710μs 17.9335μs 55.7617 KOps/s 55.2852 KOps/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[False-False-False-False-False] 41.2370μs 12.1991μs 81.9730 KOps/s 81.9634 KOps/s $\color{#35bf28}+0.01\%$
test_values[generalized_advantage_estimate-True-True] 9.7803ms 9.5250ms 104.9872 Ops/s 107.0285 Ops/s $\color{#d91a1a}-1.91\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.2574ms 35.1964ms 28.4120 Ops/s 28.9054 Ops/s $\color{#d91a1a}-1.71\%$
test_values[td0_return_estimate-False-False] 0.2326ms 0.1756ms 5.6942 KOps/s 5.5058 KOps/s $\color{#35bf28}+3.42\%$
test_values[td1_return_estimate-False-False] 26.6079ms 23.5110ms 42.5332 Ops/s 42.9655 Ops/s $\color{#d91a1a}-1.01\%$
test_values[vec_td1_return_estimate-False-False] 38.9387ms 35.2444ms 28.3733 Ops/s 28.1218 Ops/s $\color{#35bf28}+0.89\%$
test_values[td_lambda_return_estimate-True-False] 33.8830ms 33.3872ms 29.9516 Ops/s 29.6109 Ops/s $\color{#35bf28}+1.15\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.2077ms 35.1919ms 28.4157 Ops/s 28.1405 Ops/s $\color{#35bf28}+0.98\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.8597ms 8.2644ms 121.0015 Ops/s 122.4380 Ops/s $\color{#d91a1a}-1.17\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0846ms 1.7771ms 562.7027 Ops/s 550.4531 Ops/s $\color{#35bf28}+2.23\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4293ms 0.3502ms 2.8559 KOps/s 2.9092 KOps/s $\color{#d91a1a}-1.83\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 44.9658ms 43.4832ms 22.9974 Ops/s 21.7327 Ops/s $\textbf{\color{#35bf28}+5.82\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.4224ms 3.0417ms 328.7664 Ops/s 327.1675 Ops/s $\color{#35bf28}+0.49\%$
test_dqn_speed 6.2709ms 1.3657ms 732.2445 Ops/s 742.8405 Ops/s $\color{#d91a1a}-1.43\%$
test_ddpg_speed 3.7934ms 2.7168ms 368.0782 Ops/s 373.3078 Ops/s $\color{#d91a1a}-1.40\%$
test_sac_speed 9.4931ms 8.3086ms 120.3577 Ops/s 112.0459 Ops/s $\textbf{\color{#35bf28}+7.42\%}$
test_redq_speed 15.0105ms 13.5804ms 73.6356 Ops/s 75.1897 Ops/s $\color{#d91a1a}-2.07\%$
test_redq_deprec_speed 15.1578ms 13.8367ms 72.2715 Ops/s 74.2647 Ops/s $\color{#d91a1a}-2.68\%$
test_td3_speed 16.8779ms 8.3399ms 119.9049 Ops/s 122.2327 Ops/s $\color{#d91a1a}-1.90\%$
test_cql_speed 38.6740ms 36.8813ms 27.1140 Ops/s 27.0816 Ops/s $\color{#35bf28}+0.12\%$
test_a2c_speed 9.3985ms 7.9916ms 125.1314 Ops/s 128.5543 Ops/s $\color{#d91a1a}-2.66\%$
test_ppo_speed 8.5293ms 7.9199ms 126.2636 Ops/s 126.6756 Ops/s $\color{#d91a1a}-0.33\%$
test_reinforce_speed 7.7330ms 6.6352ms 150.7122 Ops/s 150.4647 Ops/s $\color{#35bf28}+0.16\%$
test_iql_speed 34.6828ms 33.1188ms 30.1943 Ops/s 30.1402 Ops/s $\color{#35bf28}+0.18\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5932ms 2.3048ms 433.8806 Ops/s 439.0147 Ops/s $\color{#d91a1a}-1.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7959ms 0.4975ms 2.0102 KOps/s 2.0038 KOps/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7977ms 0.4722ms 2.1176 KOps/s 2.1013 KOps/s $\color{#35bf28}+0.78\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7313ms 2.3903ms 418.3618 Ops/s 412.4727 Ops/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7905ms 0.4899ms 2.0411 KOps/s 2.0139 KOps/s $\color{#35bf28}+1.35\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.1144ms 0.4667ms 2.1429 KOps/s 2.1056 KOps/s $\color{#35bf28}+1.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5947ms 1.2241ms 816.9156 Ops/s 830.8806 Ops/s $\color{#d91a1a}-1.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.1228ms 1.1598ms 862.1855 Ops/s 876.2705 Ops/s $\color{#d91a1a}-1.61\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6171ms 2.3998ms 416.7089 Ops/s 412.9065 Ops/s $\color{#35bf28}+0.92\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9265ms 0.6135ms 1.6299 KOps/s 1.6225 KOps/s $\color{#35bf28}+0.45\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8772ms 0.5824ms 1.7169 KOps/s 1.6756 KOps/s $\color{#35bf28}+2.47\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5295ms 2.2711ms 440.3064 Ops/s 423.8943 Ops/s $\color{#35bf28}+3.87\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7959ms 0.5023ms 1.9909 KOps/s 1.9887 KOps/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6198ms 0.4720ms 2.1185 KOps/s 2.0856 KOps/s $\color{#35bf28}+1.58\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6699ms 2.3337ms 428.5006 Ops/s 401.6821 Ops/s $\textbf{\color{#35bf28}+6.68\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1727ms 0.4987ms 2.0052 KOps/s 1.9879 KOps/s $\color{#35bf28}+0.87\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6157ms 0.4668ms 2.1421 KOps/s 2.1283 KOps/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6624ms 2.4136ms 414.3187 Ops/s 391.4025 Ops/s $\textbf{\color{#35bf28}+5.85\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7405ms 0.6106ms 1.6377 KOps/s 1.5932 KOps/s $\color{#35bf28}+2.79\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.6847ms 0.5934ms 1.6853 KOps/s 1.6738 KOps/s $\color{#35bf28}+0.68\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1161s 5.8560ms 170.7655 Ops/s 114.6284 Ops/s $\textbf{\color{#35bf28}+48.97\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1087s 13.7955ms 72.4875 Ops/s 82.4135 Ops/s $\textbf{\color{#d91a1a}-12.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.7027ms 1.0416ms 960.0544 Ops/s 972.8463 Ops/s $\color{#d91a1a}-1.31\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1004s 5.5881ms 178.9510 Ops/s 173.5954 Ops/s $\color{#35bf28}+3.09\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.1633ms 11.9186ms 83.9022 Ops/s 83.8744 Ops/s $\color{#35bf28}+0.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6133ms 1.0466ms 955.4780 Ops/s 972.7293 Ops/s $\color{#d91a1a}-1.77\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1041s 7.9194ms 126.2725 Ops/s 119.7248 Ops/s $\textbf{\color{#35bf28}+5.47\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.3381ms 12.2628ms 81.5473 Ops/s 81.0770 Ops/s $\color{#35bf28}+0.58\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.5796ms 1.3841ms 722.4860 Ops/s 706.7506 Ops/s $\color{#35bf28}+2.23\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}15$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 98.8055ms 98.6085ms 10.1411 Ops/s 9.2536 Ops/s $\textbf{\color{#35bf28}+9.59\%}$
test_sync 87.4726ms 87.1723ms 11.4715 Ops/s 11.4045 Ops/s $\color{#35bf28}+0.59\%$
test_async 0.1578s 71.1971ms 14.0455 Ops/s 13.9999 Ops/s $\color{#35bf28}+0.33\%$
test_single_pixels 0.1797s 0.1166s 8.5776 Ops/s 8.9546 Ops/s $\color{#d91a1a}-4.21\%$
test_sync_pixels 67.1869ms 65.8001ms 15.1975 Ops/s 14.9904 Ops/s $\color{#35bf28}+1.38\%$
test_async_pixels 0.1209s 55.0797ms 18.1555 Ops/s 18.0923 Ops/s $\color{#35bf28}+0.35\%$
test_simple 0.7373s 0.6775s 1.4761 Ops/s 1.4402 Ops/s $\color{#35bf28}+2.49\%$
test_transformed 0.9496s 0.8961s 1.1159 Ops/s 1.0855 Ops/s $\color{#35bf28}+2.80\%$
test_serial 2.1088s 2.0499s 0.4878 Ops/s 0.4737 Ops/s $\color{#35bf28}+2.99\%$
test_parallel 1.8001s 1.7575s 0.5690 Ops/s 0.5609 Ops/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-True-True-True-True] 92.2610μs 31.9202μs 31.3281 KOps/s 28.9669 KOps/s $\textbf{\color{#35bf28}+8.15\%}$
test_step_mdp_speed[True-True-True-True-False] 47.5900μs 18.9724μs 52.7081 KOps/s 49.6015 KOps/s $\textbf{\color{#35bf28}+6.26\%}$
test_step_mdp_speed[True-True-True-False-True] 45.8300μs 17.9118μs 55.8292 KOps/s 52.3568 KOps/s $\textbf{\color{#35bf28}+6.63\%}$
test_step_mdp_speed[True-True-True-False-False] 31.5400μs 10.8110μs 92.4982 KOps/s 88.6704 KOps/s $\color{#35bf28}+4.32\%$
test_step_mdp_speed[True-True-False-True-True] 62.1000μs 33.3737μs 29.9637 KOps/s 27.5403 KOps/s $\textbf{\color{#35bf28}+8.80\%}$
test_step_mdp_speed[True-True-False-True-False] 48.2310μs 20.7630μs 48.1625 KOps/s 45.5390 KOps/s $\textbf{\color{#35bf28}+5.76\%}$
test_step_mdp_speed[True-True-False-False-True] 51.1110μs 19.8562μs 50.3622 KOps/s 47.5410 KOps/s $\textbf{\color{#35bf28}+5.93\%}$
test_step_mdp_speed[True-True-False-False-False] 34.0300μs 12.6854μs 78.8308 KOps/s 75.2179 KOps/s $\color{#35bf28}+4.80\%$
test_step_mdp_speed[True-False-True-True-True] 61.7910μs 36.0980μs 27.7023 KOps/s 26.0670 KOps/s $\textbf{\color{#35bf28}+6.27\%}$
test_step_mdp_speed[True-False-True-True-False] 44.6610μs 23.0921μs 43.3049 KOps/s 41.5631 KOps/s $\color{#35bf28}+4.19\%$
test_step_mdp_speed[True-False-True-False-True] 42.1610μs 20.0931μs 49.7683 KOps/s 47.5706 KOps/s $\color{#35bf28}+4.62\%$
test_step_mdp_speed[True-False-True-False-False] 96.7820μs 12.8819μs 77.6282 KOps/s 74.6956 KOps/s $\color{#35bf28}+3.93\%$
test_step_mdp_speed[True-False-False-True-True] 64.1300μs 37.6749μs 26.5429 KOps/s 25.3169 KOps/s $\color{#35bf28}+4.84\%$
test_step_mdp_speed[True-False-False-True-False] 44.2000μs 24.7558μs 40.3946 KOps/s 38.5816 KOps/s $\color{#35bf28}+4.70\%$
test_step_mdp_speed[True-False-False-False-True] 47.4510μs 21.8051μs 45.8609 KOps/s 44.0063 KOps/s $\color{#35bf28}+4.21\%$
test_step_mdp_speed[True-False-False-False-False] 30.9400μs 14.5921μs 68.5304 KOps/s 66.1812 KOps/s $\color{#35bf28}+3.55\%$
test_step_mdp_speed[False-True-True-True-True] 65.1420μs 36.2255μs 27.6049 KOps/s 26.5821 KOps/s $\color{#35bf28}+3.85\%$
test_step_mdp_speed[False-True-True-True-False] 41.3810μs 23.1163μs 43.2595 KOps/s 42.1299 KOps/s $\color{#35bf28}+2.68\%$
test_step_mdp_speed[False-True-True-False-True] 42.1310μs 24.1196μs 41.4601 KOps/s 40.0526 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-True-True-False-False] 36.2200μs 14.5675μs 68.6461 KOps/s 66.0843 KOps/s $\color{#35bf28}+3.88\%$
test_step_mdp_speed[False-True-False-True-True] 65.2910μs 37.6993μs 26.5257 KOps/s 25.2615 KOps/s $\textbf{\color{#35bf28}+5.00\%}$
test_step_mdp_speed[False-True-False-True-False] 44.7300μs 24.8331μs 40.2688 KOps/s 38.3525 KOps/s $\color{#35bf28}+5.00\%$
test_step_mdp_speed[False-True-False-False-True] 71.3710μs 25.7403μs 38.8496 KOps/s 37.6891 KOps/s $\color{#35bf28}+3.08\%$
test_step_mdp_speed[False-True-False-False-False] 34.0900μs 16.3843μs 61.0339 KOps/s 58.6348 KOps/s $\color{#35bf28}+4.09\%$
test_step_mdp_speed[False-False-True-True-True] 63.9110μs 40.0234μs 24.9854 KOps/s 23.8127 KOps/s $\color{#35bf28}+4.92\%$
test_step_mdp_speed[False-False-True-True-False] 47.3600μs 26.7310μs 37.4098 KOps/s 35.8618 KOps/s $\color{#35bf28}+4.32\%$
test_step_mdp_speed[False-False-True-False-True] 44.3800μs 26.2221μs 38.1357 KOps/s 37.2107 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[False-False-True-False-False] 43.2710μs 16.6158μs 60.1837 KOps/s 59.2165 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[False-False-False-True-True] 64.7800μs 41.2455μs 24.2451 KOps/s 23.3389 KOps/s $\color{#35bf28}+3.88\%$
test_step_mdp_speed[False-False-False-True-False] 50.1900μs 28.6090μs 34.9541 KOps/s 34.1839 KOps/s $\color{#35bf28}+2.25\%$
test_step_mdp_speed[False-False-False-False-True] 50.8810μs 27.1101μs 36.8867 KOps/s 35.6782 KOps/s $\color{#35bf28}+3.39\%$
test_step_mdp_speed[False-False-False-False-False] 39.2410μs 18.2520μs 54.7885 KOps/s 53.5022 KOps/s $\color{#35bf28}+2.40\%$
test_values[generalized_advantage_estimate-True-True] 26.6194ms 26.1491ms 38.2423 Ops/s 39.6602 Ops/s $\color{#d91a1a}-3.58\%$
test_values[vec_generalized_advantage_estimate-True-True] 80.1804ms 3.1608ms 316.3779 Ops/s 315.9827 Ops/s $\color{#35bf28}+0.13\%$
test_values[td0_return_estimate-False-False] 91.2810μs 63.0437μs 15.8620 KOps/s 15.0053 KOps/s $\textbf{\color{#35bf28}+5.71\%}$
test_values[td1_return_estimate-False-False] 56.2439ms 55.0093ms 18.1788 Ops/s 18.5741 Ops/s $\color{#d91a1a}-2.13\%$
test_values[vec_td1_return_estimate-False-False] 2.0684ms 1.7731ms 563.9745 Ops/s 566.6925 Ops/s $\color{#d91a1a}-0.48\%$
test_values[td_lambda_return_estimate-True-False] 90.4492ms 89.8195ms 11.1334 Ops/s 11.6457 Ops/s $\color{#d91a1a}-4.40\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0976ms 1.7712ms 564.5930 Ops/s 565.3683 Ops/s $\color{#d91a1a}-0.14\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.2613ms 24.8622ms 40.2218 Ops/s 41.9584 Ops/s $\color{#d91a1a}-4.14\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8833ms 0.7138ms 1.4010 KOps/s 1.4140 KOps/s $\color{#d91a1a}-0.92\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7682ms 0.6720ms 1.4880 KOps/s 1.5335 KOps/s $\color{#d91a1a}-2.97\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5761ms 1.4707ms 679.9468 Ops/s 684.8979 Ops/s $\color{#d91a1a}-0.72\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9420ms 0.6854ms 1.4591 KOps/s 1.4877 KOps/s $\color{#d91a1a}-1.92\%$
test_dqn_speed 1.6983ms 1.4128ms 707.7936 Ops/s 670.3727 Ops/s $\textbf{\color{#35bf28}+5.58\%}$
test_ddpg_speed 2.9726ms 2.6949ms 371.0743 Ops/s 355.7421 Ops/s $\color{#35bf28}+4.31\%$
test_sac_speed 94.9637ms 8.6910ms 115.0618 Ops/s 121.2559 Ops/s $\textbf{\color{#d91a1a}-5.11\%}$
test_redq_speed 10.9568ms 10.0717ms 99.2879 Ops/s 96.5553 Ops/s $\color{#35bf28}+2.83\%$
test_redq_deprec_speed 11.6631ms 11.1528ms 89.6637 Ops/s 91.0113 Ops/s $\color{#d91a1a}-1.48\%$
test_td3_speed 8.0865ms 7.8894ms 126.7529 Ops/s 122.6128 Ops/s $\color{#35bf28}+3.38\%$
test_cql_speed 26.1499ms 24.9525ms 40.0762 Ops/s 39.2489 Ops/s $\color{#35bf28}+2.11\%$
test_a2c_speed 5.7820ms 5.5347ms 180.6796 Ops/s 181.3879 Ops/s $\color{#d91a1a}-0.39\%$
test_ppo_speed 6.7835ms 5.8562ms 170.7590 Ops/s 171.6266 Ops/s $\color{#d91a1a}-0.51\%$
test_reinforce_speed 4.8916ms 4.5361ms 220.4526 Ops/s 222.1187 Ops/s $\color{#d91a1a}-0.75\%$
test_iql_speed 19.9632ms 19.1399ms 52.2469 Ops/s 51.4860 Ops/s $\color{#35bf28}+1.48\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9618ms 2.8523ms 350.5926 Ops/s 340.5940 Ops/s $\color{#35bf28}+2.94\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6873ms 0.5430ms 1.8416 KOps/s 1.8599 KOps/s $\color{#d91a1a}-0.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5743ms 0.5227ms 1.9132 KOps/s 1.9324 KOps/s $\color{#d91a1a}-1.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0641ms 2.8793ms 347.3092 Ops/s 341.3800 Ops/s $\color{#35bf28}+1.74\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0235ms 0.5335ms 1.8742 KOps/s 1.8810 KOps/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6524ms 0.5114ms 1.9555 KOps/s 1.9610 KOps/s $\color{#d91a1a}-0.28\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6393ms 1.4315ms 698.5660 Ops/s 593.5430 Ops/s $\textbf{\color{#35bf28}+17.69\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 5.2127ms 1.3750ms 727.2831 Ops/s 744.7063 Ops/s $\color{#d91a1a}-2.34\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1613ms 2.9935ms 334.0580 Ops/s 324.9018 Ops/s $\color{#35bf28}+2.82\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1320s 0.7664ms 1.3048 KOps/s 1.5089 KOps/s $\textbf{\color{#d91a1a}-13.52\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7978ms 0.6398ms 1.5630 KOps/s 1.5504 KOps/s $\color{#35bf28}+0.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0240ms 2.8673ms 348.7624 Ops/s 341.7928 Ops/s $\color{#35bf28}+2.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6522ms 0.5460ms 1.8316 KOps/s 1.8484 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6879ms 0.5231ms 1.9118 KOps/s 1.9075 KOps/s $\color{#35bf28}+0.22\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1198ms 2.8862ms 346.4758 Ops/s 338.1830 Ops/s $\color{#35bf28}+2.45\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6675ms 0.5392ms 1.8545 KOps/s 1.8788 KOps/s $\color{#d91a1a}-1.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5075ms 0.5158ms 1.9389 KOps/s 1.9565 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1938ms 3.0078ms 332.4736 Ops/s 327.1249 Ops/s $\color{#35bf28}+1.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7708ms 0.6658ms 1.5019 KOps/s 1.5077 KOps/s $\color{#d91a1a}-0.38\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8444ms 0.6448ms 1.5508 KOps/s 1.5425 KOps/s $\color{#35bf28}+0.54\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1317s 7.4051ms 135.0420 Ops/s 135.3272 Ops/s $\color{#d91a1a}-0.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.6406ms 14.3097ms 69.8825 Ops/s 68.6407 Ops/s $\color{#35bf28}+1.81\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1537ms 1.0284ms 972.4015 Ops/s 924.9509 Ops/s $\textbf{\color{#35bf28}+5.13\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1193s 9.2563ms 108.0350 Ops/s 141.5574 Ops/s $\textbf{\color{#d91a1a}-23.68\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.6592ms 14.3472ms 69.7000 Ops/s 68.6304 Ops/s $\color{#35bf28}+1.56\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1133ms 1.0357ms 965.5212 Ops/s 916.2236 Ops/s $\textbf{\color{#35bf28}+5.38\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1174s 7.4042ms 135.0580 Ops/s 103.3333 Ops/s $\textbf{\color{#35bf28}+30.70\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9544ms 14.6482ms 68.2676 Ops/s 66.8141 Ops/s $\color{#35bf28}+2.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5880ms 1.4415ms 693.7049 Ops/s 709.4354 Ops/s $\color{#d91a1a}-2.22\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot