Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use default device instead of CPU in losses #2687

Merged
merged 9 commits into from
Jan 16, 2025
Merged

[Refactor] Use default device instead of CPU in losses #2687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5636edf
Update
vmoens Jan 10, 2025
6ef57a4
Update
vmoens Jan 10, 2025
399b618
Update
vmoens Jan 10, 2025
6dc021b
Update
vmoens Jan 13, 2025
09ff2c8
Update
vmoens Jan 15, 2025
1d88f7a
Update
vmoens Jan 15, 2025
955c0af
Update
vmoens Jan 15, 2025
efa534f
Update
vmoens Jan 15, 2025
d2585fa
Update
vmoens Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchrl/objectives/cql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()
self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
if bool(min_alpha) ^ bool(max_alpha):
min_alpha = min_alpha if min_alpha else 0.0
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/crossq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()
self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
if bool(min_alpha) ^ bool(max_alpha):
min_alpha = min_alpha if min_alpha else 0.0
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/decision_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()

self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
if bool(min_alpha) ^ bool(max_alpha):
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/deprecated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()

self.register_buffer("alpha_init", torch.as_tensor(alpha_init, device=device))
self.register_buffer(
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/ppo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ def __init__(
try:
device = next(self.parameters()).device
except (AttributeError, StopIteration):
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()

self.register_buffer("entropy_coef", torch.tensor(entropy_coef, device=device))
if critic_coef is not None:
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/redq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()

self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
self.register_buffer(
Expand Down
4 changes: 2 additions & 2 deletions torchrl/objectives/sac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()
self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
if bool(min_alpha) ^ bool(max_alpha):
min_alpha = min_alpha if min_alpha else 0.0
Expand Down Expand Up @@ -1121,7 +1121,7 @@ def __init__(
try:
device = next(self.parameters()).device
except AttributeError:
device = torch.device("cpu")
device = getattr(torch, "get_default_device", lambda: torch.device("cpu"))()

self.register_buffer("alpha_init", torch.tensor(alpha_init, device=device))
if bool(min_alpha) ^ bool(max_alpha):
Expand Down
Loading