Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set warning upload artifacts when check-artifact step return error #6286

Merged
merged 13 commits into from
Feb 13, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Feb 13, 2025

related to issue: pytorch/executorch#8125

example run: https://github.com/pytorch/executorch/actions/runs/13275229180/job/37063477575

Set defult warning for missing artifact
image

add test for no artifacts

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:35am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2025
@yangw-dev yangw-dev changed the title [skip upload artifacts] skip upload artifacts when check-artifact step return error Feb 13, 2025
@yangw-dev yangw-dev requested a review from huydhn February 13, 2025 00:55
@yangw-dev yangw-dev marked this pull request as ready for review February 13, 2025 00:55
@yangw-dev yangw-dev removed the request for review from huydhn February 13, 2025 01:06
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to do the same for linux_job.yml too for consistency

@yangw-dev
Copy link
Contributor Author

yangw-dev commented Feb 13, 2025

You probably want to do the same for linux_job.yml too for consistency

will do!
this is the warning looks like fyi
image

@yangw-dev yangw-dev changed the title skip upload artifacts when check-artifact step return error set warning upload artifacts when check-artifact step return error Feb 13, 2025
@yangw-dev yangw-dev merged commit ae56320 into main Feb 13, 2025
40 checks passed
@yangw-dev yangw-dev deleted the signals3 branch February 13, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants