-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ARM CPU experimental kernels from AO to leverage pip install #1458
base: main
Are you sure you want to change the base?
Conversation
metascroy
commented
Jan 15, 2025
- torchao experimental CPU kernels are now installed and loaded automatically by pip.
- Switch quantization to use new quantize_ API
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1458
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 67dd729 with merge base e5cf6e5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the pip install work with the subclass APIs!!
cc: @manuelcandales Can have please for MPS? 🥺🥺 (Separate PR) |
Awaiting pytorch/executorch#7759 |
@Jack-Khuu did you update the version AO uses in ET? |
Yup pytorch/executorch@9836b39 Points to pytorch/ao@11333ba |
Co-authored-by: Jack-Khuu <[email protected]>
Co-authored-by: Jack-Khuu <[email protected]>
Co-authored-by: Jack-Khuu <[email protected]>
8ebf63f
to
0abe175
Compare
Hello @metascroy @Jack-Khuu , what is the plan to get this in mainline? We would like to use KleidiAI kernels from aten via this quantizer path. Let us know if we need to raise a new PR ? |
Hi @nikhil-arm, we're still planning to land this Can you share the specific commit hashes y'all need? |
@nikhil-arm We've bumped the AO pin on main. |
After a suite of rebases, pinbumps, and splitting up tests up we know what we're tackling:
|
Sorry about the delay @nikhil-arm. @Jack-Khuu let's try to get this landed within the next week. Bumping the ao pin in torchchat had various conflicts with the CI, but I think we can dedicate to making this work. I think it does make sense to first land pytorch/ao#1836 in torchao before bumping because they've already deprecated the old quantizers in quantize_. |