Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARM CPU experimental kernels from AO to leverage pip install #1458

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

metascroy
Copy link
Contributor

  • torchao experimental CPU kernels are now installed and loaded automatically by pip.
  • Switch quantization to use new quantize_ API

@metascroy metascroy requested a review from Jack-Khuu January 15, 2025 21:14
Copy link

pytorch-bot bot commented Jan 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1458

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 67dd729 with merge base e5cf6e5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 15, 2025
@Jack-Khuu Jack-Khuu added the Quantization Issues related to Quantization or torchao label Jan 15, 2025
Copy link
Contributor

@Jack-Khuu Jack-Khuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the pip install work with the subclass APIs!!

@Jack-Khuu Jack-Khuu changed the title update experimental kernels in torchchat Update ARM CPU experimental kernels from AO to leverage pip install Jan 15, 2025
@Jack-Khuu
Copy link
Contributor

cc: @manuelcandales

Can have please for MPS? 🥺🥺 (Separate PR)

@Jack-Khuu
Copy link
Contributor

Awaiting pytorch/executorch#7759

@metascroy
Copy link
Contributor Author

@Jack-Khuu did you update the version AO uses in ET?

@Jack-Khuu
Copy link
Contributor

Yup pytorch/executorch@9836b39 Points to pytorch/ao@11333ba

@nikhil-arm
Copy link

Hello @metascroy @Jack-Khuu , what is the plan to get this in mainline? We would like to use KleidiAI kernels from aten via this quantizer path. Let us know if we need to raise a new PR ?

@Jack-Khuu
Copy link
Contributor

Hi @nikhil-arm, we're still planning to land this

Can you share the specific commit hashes y'all need?

@Jack-Khuu
Copy link
Contributor

@nikhil-arm We've bumped the AO pin on main.
Please let me know if you there's any additional support needed to unblock KleidiAI kernels

@Jack-Khuu
Copy link
Contributor

After a suite of rebases, pinbumps, and splitting up tests up we know what we're tackling:

  • test-torchao-experimental-cpp (macos-14-xlarge): Tests the AOTI runner and likely failing (also in main) due to not linking to the LibOMP from torch as @malfet mentioned in Bump PT 2025131 and ET pins 20250209 #1493.

  • test-torchao-experimental-et (macos-14-xlarge): Tests the ET runner; looks like a install bug where USE_CPP isn't set, but will likely run into the same LibOMP issue as above

@metascroy
Copy link
Contributor Author

Hello @metascroy @Jack-Khuu , what is the plan to get this in mainline? We would like to use KleidiAI kernels from aten via this quantizer path. Let us know if we need to raise a new PR ?

Sorry about the delay @nikhil-arm.

@Jack-Khuu let's try to get this landed within the next week. Bumping the ao pin in torchchat had various conflicts with the CI, but I think we can dedicate to making this work.

I think it does make sense to first land pytorch/ao#1836 in torchao before bumping because they've already deprecated the old quantizers in quantize_.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Quantization Issues related to Quantization or torchao
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants